Refactoring

src/containers/Configuration/Configuration.js

@@ -246,9 +246,8 @@ class Configuration extends IPCContainer {
         Saving: true,
       },
       () => {
-        const changedItems = [];
-        for (const item of this.state.ChangedItems) {
-          changedItems.push({
+        let changedItems = this.state.ChangedItems.map((item) => {
+          return {
             Name: item.label,
             Value:
               item.type === 'string_array'
@@ -256,13 +255,14 @@ class Configuration extends IPCContainer {
                 : item.type === 'host_list'
                 ? JSON.stringify(item.value)
                 : item.value,
+          };
         });
-        }
 
         if (this.state.ChangedObjectLookup) {
           for (const key of Object.keys(this.state.ChangedObjectLookup)) {
-            for (const item of this.state.ChangedObjectLookup[key]) {
-              changedItems.push({
+            changedItems = changedItems.concat(
+              this.state.ChangedObjectLookup[key].map((item) => {
+                return {
                   Name: key + '.' + item.label,
                   Value:
                     item.type === 'string_array'
@@ -270,8 +270,9 @@ class Configuration extends IPCContainer {
                       : item.type === 'host_list'
                       ? JSON.stringify(item.value)
                       : item.value,
-              });
-            }
+                };
+              })
+            );
           }
         }
 
@@ -346,13 +347,13 @@ class Configuration extends IPCContainer {
       autoFocus = value;
     };
 
-    let objectItems = [];
-    for (const key of Object.keys(this.state.ObjectLookup)) {
-      objectItems.push(
+    const objectItems = Object.keys(this.state.ObjectLookup).map((key) => {
+      return (
         <div key={key}>
           <h2>{key}</h2>
           <div>
-            {this.state.ObjectLookup[key].map((k, i) => {
+            {this.state.ObjectLookup[key]
+              .map((k, i) => {
                 const shouldFocus = getAutoFocus();
                 setAutoFocus(false);
                 return !k.advanced ||
@@ -374,11 +375,12 @@ class Configuration extends IPCContainer {
                     value={k.value}
                   />
                 ) : null;
-            })}
+              })
+              .filter((i) => i !== null)}
           </div>
         </div>
       );
-    }
+    });
 
     const configurationItems = this.state.ItemList.map((k, i) => {
       const shouldFocus = autoFocus;
@@ -397,7 +399,7 @@ class Configuration extends IPCContainer {
           value={k.value}
         />
       ) : null;
-    });
+    }).filter((i) => i !== null);
 
     return (
       <div className={'Configuration'}>