[#52: Mount location is not set error on new install] [#49: Download progress is not visible if dependencies are missing] [#51: javascript error] [#53: Busy notification is still visible when 'Install' button is available]

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
+
+## 1.3.3
+
+* \#49: Download progress is not visible if dependencies are missing
+* \#51: javascript error
+* \#52: Mount location is not set error on new install
+* \#53: Busy notification is still visible when 'Install' button is available
+
 ## 1.3.2
+
 * \#48: Support pinning files to cache
 * Fixed Skynet export display
 * Properly detect existing remote

src/App.jsx

@@ -98,7 +98,7 @@ class App extends IPCContainer {
       !this.props.DownloadActive &&
       (selectedVersion !== 'unavailable') &&
       (selectedVersion !== this.props.InstalledVersion);
-
+    console.log(selectedVersion);
     const missingDependencies = (this.props.MissingDependencies.length > 0) &&
       this.props.AllowMount;
 
@@ -230,7 +230,7 @@ class App extends IPCContainer {
                         skynetSupported={skynetSupported}/>
           </Box>
         ));
-      } else if (selectedVersion !== 'unavailable') {
+      } else if (!downloadEnabled && (selectedVersion !== 'unavailable')) {
         mainContent.push((
           <Box dxStyle={{padding: 'var(--default_spacing)', height: '170px'}}
                key={'md_' + key++}>

src/components/NewReleases/NewRelease/NewRelease.js

@@ -9,6 +9,12 @@ import {
 } from '../../../redux/actions/error_actions';
 import {installReleaseByVersion} from '../../../redux/actions/install_actions';
 
+const mapStateToProps = state => {
+  return {
+    AllowInstall: state.install.MissingDependencies.length === 0,
+  };
+};
+
 const mapDispatchToProps = dispatch => {
   return {
     installReleaseByVersion: (release, version) => dispatch(installReleaseByVersion(release, version)),
@@ -17,7 +23,15 @@ const mapDispatchToProps = dispatch => {
   };
 };
 
-export default connect(null, mapDispatchToProps)(({dismiss, release, lastItem, notifyError, notifyInfo, installReleaseByVersion}) => {
+export default connect(mapStateToProps, mapDispatchToProps)(({
+                                                               AllowInstall,
+                                                               dismiss,
+                                                               release,
+                                                               lastItem,
+                                                               notifyError,
+                                                               notifyInfo,
+                                                               installReleaseByVersion
+                                                             }) => {
   const title = '[' + Constants.RELEASE_TYPES[release.Release] + '] ' + release.Display;
   const installReleaseVersion = () => {
     dismiss();
@@ -46,7 +60,9 @@ export default connect(null, mapDispatchToProps)(({dismiss, release, lastItem, n
             <div style={{width: 'var(--default_spacing)'}}/>
           </td>
           <td width="50%">
-            <Button buttonStyles={{width: '100%'}} clicked={installReleaseVersion}>Install</Button>
+            {AllowInstall ?
+              <Button buttonStyles={{width: '100%'}}
+                      clicked={installReleaseVersion}>Install</Button> : null}
           </td>
         </tr>
         {lastItem ? null : <tr style={{height: 'var(--default_spacing)'}}/>}

src/containers/MountItems/MountItems.js

@@ -304,15 +304,12 @@ class MountItems extends IPCContainer {
     const providerState = this.props.ProviderState[provider];
     if (location.length === 0) {
       location = (this.props.Platform === 'win32') ?
-        providerState.MountLocation || driveLetters[0] :
+        !providerState.MountLocation || providerState.MountLocation.trim().length === 0 ? driveLetters[0] : providerState.MountLocation :
         providerState.MountLocation;
     }
 
     if (location !== providerState.MountLocation) {
-      const value = (this.props.Platform === 'win32') ?
+      this.handleMountLocationChanged(provider, location);
-        driveLetters.indexOf(location) :
-        location;
-      this.handleMountLocationChanged(provider, value);
     }
 
     if (!this.props.AutoMountProcessed[provider] &&

src/helpers.js

@@ -188,7 +188,7 @@ const _execProcessGetOutput = (cmd, working, args) => {
     }
     const proc = spawn(cmd, args, processOptions);
 
-    let output;
+    let output = '';
     proc.stdout.on('data', data => { output += data.toString(); });
 
     proc.on('error', (err) => { reject(err); });