From 0add5ec944685096248ff3e0f08197b5a613e9b2 Mon Sep 17 00:00:00 2001 From: "Scott E. Graves" Date: Sat, 15 Mar 2025 22:56:23 -0500 Subject: [PATCH] refactor --- web/repertory/lib/widgets/mount_settings.dart | 76 +++++++++---------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/web/repertory/lib/widgets/mount_settings.dart b/web/repertory/lib/widgets/mount_settings.dart index 26bed8ba..50c6cced 100644 --- a/web/repertory/lib/widgets/mount_settings.dart +++ b/web/repertory/lib/widgets/mount_settings.dart @@ -150,40 +150,6 @@ class _MountSettingsWidgetState extends State { } } - void _addListSetting( - list, - root, - key, - value, - List valueList, - icon, - isAdvanced, - ) { - if (!isAdvanced || widget.showAdvanced) { - list.add( - SettingsTile.navigation( - title: Text(key), - leading: Icon(icon), - value: DropdownButton( - value: value, - onChanged: - (newValue) => setState(() { - root[key] = newValue; - widget.onChanged?.call(widget.settings); - }), - items: - valueList.map>((item) { - return DropdownMenuItem( - value: item, - child: Text(item), - ); - }).toList(), - ), - ), - ); - } - } - void _addPasswordSetting( list, root, @@ -270,6 +236,40 @@ class _MountSettingsWidgetState extends State { } } + void _addStringListSetting( + list, + root, + key, + value, + List valueList, + icon, + isAdvanced, + ) { + if (!isAdvanced || widget.showAdvanced) { + list.add( + SettingsTile.navigation( + title: Text(key), + leading: Icon(icon), + value: DropdownButton( + value: value, + onChanged: + (newValue) => setState(() { + root[key] = newValue; + widget.onChanged?.call(widget.settings); + }), + items: + valueList.map>((item) { + return DropdownMenuItem( + value: item, + child: Text(item), + ); + }).toList(), + ), + ), + ); + } + } + void _addStringSetting( list, root, @@ -385,7 +385,7 @@ class _MountSettingsWidgetState extends State { break; case 'DatabaseType': { - _addListSetting( + _addStringListSetting( commonSettings, widget.settings, key, @@ -432,7 +432,7 @@ class _MountSettingsWidgetState extends State { break; case 'EventLevel': { - _addListSetting( + _addStringListSetting( commonSettings, widget.settings, key, @@ -504,7 +504,7 @@ class _MountSettingsWidgetState extends State { break; case 'PreferredDownloadType': { - _addListSetting( + _addStringListSetting( commonSettings, widget.settings, key, @@ -720,7 +720,7 @@ class _MountSettingsWidgetState extends State { break; case 'Protocol': { - _addListSetting( + _addStringListSetting( hostConfigSettings, widget.settings[key], subKey,