extract common behavior

include/providers/base_provider.hpp

@@ -83,6 +83,10 @@ protected:
     return config_;
   }
 
+  [[nodiscard]] virtual auto
+  get_directory_items_impl(const std::string &api_path,
+                           directory_item_list &list) const -> api_error = 0;
+
   [[nodiscard]] auto get_db() const -> rocksdb::DB * { return db_.get(); }
 
   [[nodiscard]] auto get_file_mgr() -> i_file_manager * { return fm_; }
@@ -107,6 +111,10 @@ public:
                                               std::string &api_path) const
       -> api_error override;
 
+  [[nodiscard]] auto get_directory_items(const std::string &api_path,
+                                         directory_item_list &list) const
+      -> api_error override;
+
   [[nodiscard]] auto get_file_size(const std::string &api_path,
                                    std::uint64_t &file_size) const
       -> api_error override;

include/providers/s3/s3_provider.hpp

@@ -49,10 +49,6 @@ private:
                                       const std::string &object_name) const
       -> api_error;
 
-  [[nodiscard]] auto create_directory_impl(const std::string &api_path,
-                                           api_meta_map &meta)
-      -> api_error override;
-
   [[nodiscard]] auto create_file_extra(const std::string &api_path,
                                        api_meta_map &meta)
       -> api_error override;
@@ -75,14 +71,19 @@ private:
                   std::optional<std::string> prefix = std::nullopt) const
       -> bool;
 
+protected:
+  [[nodiscard]] auto create_directory_impl(const std::string &api_path,
+                                           api_meta_map &meta)
+      -> api_error override;
+
+  [[nodiscard]] auto get_directory_items_impl(const std::string &api_path,
+                                              directory_item_list &list) const
+      -> api_error override;
+
 public:
   [[nodiscard]] auto get_directory_item_count(const std::string &api_path) const
       -> std::uint64_t override;
 
-  [[nodiscard]] auto get_directory_items(const std::string &api_path,
-                                         directory_item_list &list) const
-      -> api_error override;
-
   [[nodiscard]] auto get_file(const std::string &api_path, api_file &file) const
       -> api_error override;
 

include/providers/sia/sia_provider.hpp

@@ -54,14 +54,14 @@ protected:
                                            api_meta_map &meta)
       -> api_error override;
 
+  [[nodiscard]] auto get_directory_items_impl(const std::string &api_path,
+                                              directory_item_list &list) const
+      -> api_error override;
+
 public:
   [[nodiscard]] auto get_directory_item_count(const std::string &api_path) const
       -> std::uint64_t override;
 
-  [[nodiscard]] auto get_directory_items(const std::string &api_path,
-                                         directory_item_list &list) const
-      -> api_error override;
-
   [[nodiscard]] auto get_file(const std::string &api_path, api_file &file) const
       -> api_error override;