BlockStorage/repertory
1
0
Fork 0
Code Issues 7 Pull Requests Releases 6 Wiki Activity

winfsp unit tests and fixes

Browse Source
This commit is contained in:
Scott E. Graves 2024-11-09 11:50:27 -06:00
parent 136f76c575
commit 3338fcf91f
2 changed files with 132 additions and 112 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
repertory/librepertory/src/drives/winfsp/winfsp_drive.cpp
View File

@ -848,6 +848,10 @@ auto winfsp_drive::Read(PVOID /*file_node*/, PVOID file_desc, PVOID buffer,
api_path = file->get_api_path(); api_path = file->get_api_path();
if (offset >= file->get_file_size()) {
return STATUS_END_OF_FILE;
}
if (length == 0U) { if (length == 0U) {
return handle_error(api_error::success); return handle_error(api_error::success);
} }
@ -859,19 +863,22 @@ auto winfsp_drive::Read(PVOID /*file_node*/, PVOID file_desc, PVOID buffer,
} }
*bytes_transferred = static_cast<ULONG>(data.size()); *bytes_transferred = static_cast<ULONG>(data.size());
if ((length > 0) && (data.size() != length)) {
auto short_read = data.size() != length;
if (not data.empty()) {
::CopyMemory(buffer, data.data(), data.size());
data.clear();
}
auto ret = handle_error(provider_.set_item_meta(
api_path, META_ACCESSED, std::to_string(utils::time::get_time_now())));
if (short_read) {
::SetLastError(ERROR_HANDLE_EOF); ::SetLastError(ERROR_HANDLE_EOF);
} }
if (data.empty()) { return ret;
return handle_error(api_error::success);
}
::CopyMemory(buffer, data.data(), data.size());
data.clear();
return handle_error(provider_.set_item_meta(
api_path, META_ACCESSED, std::to_string(utils::time::get_time_now())));
} }
auto winfsp_drive::ReadDirectory(PVOID /*file_node*/, PVOID file_desc, auto winfsp_drive::ReadDirectory(PVOID /*file_node*/, PVOID file_desc,

217
repertory/repertory_test/src/winfsp_drive_rdrw_test.cpp
View File

@ -290,112 +290,124 @@ static void test_overlapped_file(auto mount_location, auto &&file_path,
EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError()); EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError());
EXPECT_TRUE(::GetOverlappedResult(handle, &overlapped, &bytes_written, TRUE)); EXPECT_TRUE(::GetOverlappedResult(handle, &overlapped, &bytes_written, TRUE));
EXPECT_EQ(bytes_per_sector, bytes_written); EXPECT_EQ(bytes_per_sector, bytes_written);
//
// Overlapped.Offset = 2 * BytesPerSector; overlapped.Offset = 2U * bytes_per_sector;
// Success = WriteFile(Handle, Buffer[0], BytesPerSector, &BytesTransferred, ret = ::WriteFile(handle, write_buffer.data(), bytes_per_sector,
// &Overlapped); &bytes_written, &overlapped);
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError());
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, EXPECT_TRUE(::GetOverlappedResult(handle, &overlapped, &bytes_written, TRUE));
// TRUE); ASSERT(Success); ASSERT(BytesPerSector == BytesTransferred); EXPECT_EQ(bytes_per_sector, bytes_written);
//
// Overlapped.Offset = 0; data_buffer read_buffer{};
// memset(AllocBuffer[1], 0, AllocBufferSize); read_buffer.resize(buffer_size);
// Success = ReadFile(Handle, Buffer[1], BytesPerSector, &BytesTransferred, overlapped.Offset = 0U;
// &Overlapped); DWORD bytes_read{};
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); ret = ::ReadFile(handle, read_buffer.data(), bytes_per_sector, &bytes_read,
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, &overlapped);
// TRUE); ASSERT(Success); ASSERT(BytesPerSector == BytesTransferred);
// ASSERT(0 == memcmp(Buffer[0], Buffer[1], BytesTransferred)); EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError());
// EXPECT_TRUE(::GetOverlappedResult(handle, &overlapped, &bytes_read, TRUE));
// Overlapped.Offset = 2 * BytesPerSector;
// memset(AllocBuffer[1], 0, AllocBufferSize); EXPECT_EQ(bytes_per_sector, bytes_read);
// Success = ReadFile(Handle, Buffer[1], BytesPerSector, &BytesTransferred, EXPECT_EQ(0,
// &Overlapped); std::memcmp(write_buffer.data(), read_buffer.data(), bytes_read));
// ASSERT(Success || ERROR_IO_PENDING == GetLastError());
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, read_buffer.clear();
// TRUE); ASSERT(Success); ASSERT(BytesPerSector == BytesTransferred); read_buffer.resize(buffer_size);
// ASSERT(0 == memcmp(Buffer[0], Buffer[1], BytesTransferred)); overlapped.Offset = 2U * bytes_per_sector;
// ret = ::ReadFile(handle, read_buffer.data(), bytes_per_sector, &bytes_read,
// Overlapped.Offset = 2 * BytesPerSector; &overlapped);
// memset(AllocBuffer[1], 0, AllocBufferSize); EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError());
// Success = ReadFile(Handle, Buffer[1], 2 * BytesPerSector, EXPECT_TRUE(::GetOverlappedResult(handle, &overlapped, &bytes_read, TRUE));
// &BytesTransferred, EXPECT_EQ(bytes_per_sector, bytes_read);
// &Overlapped); EXPECT_EQ(0,
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); std::memcmp(write_buffer.data(), read_buffer.data(), bytes_read));
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred,
// TRUE); ASSERT(Success); ASSERT(BytesPerSector == BytesTransferred); read_buffer.clear();
// ASSERT(0 == memcmp(Buffer[0], Buffer[1], BytesTransferred)); read_buffer.resize(buffer_size);
// overlapped.Offset = 2U * bytes_per_sector;
// Overlapped.Offset = 3 * BytesPerSector; ret = ::ReadFile(handle, read_buffer.data(), 2U * bytes_per_sector,
// memset(AllocBuffer[1], 0, AllocBufferSize); &bytes_read, &overlapped);
// Success = ReadFile(Handle, Buffer[1], BytesPerSector, &BytesTransferred, EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError());
// &Overlapped); EXPECT_TRUE(::GetOverlappedResult(handle, &overlapped, &bytes_read, TRUE));
// ASSERT(Success || ERROR_IO_PENDING == GetLastError() || EXPECT_EQ(bytes_per_sector, bytes_read);
// ERROR_HANDLE_EOF == GetLastError()); EXPECT_EQ(0,
// if (ERROR_HANDLE_EOF != GetLastError()) { std::memcmp(write_buffer.data(), read_buffer.data(), bytes_read));
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred,
// TRUE); ASSERT(!Success && ERROR_HANDLE_EOF == GetLastError()); read_buffer.clear();
// } read_buffer.resize(buffer_size);
// ASSERT(0 == BytesTransferred); overlapped.Offset = 3U * bytes_per_sector;
// ASSERT(0 == memcmp(Buffer[0], Buffer[1], BytesTransferred)); ret = ::ReadFile(handle, read_buffer.data(), bytes_per_sector, &bytes_read,
// &overlapped);
// Overlapped.Offset = 0; EXPECT_TRUE(ret || ERROR_IO_PENDING == ::GetLastError() ||
// Success = WriteFile(Handle, Buffer[0], 2 * SystemInfo.dwPageSize, ERROR_HANDLE_EOF == ::GetLastError());
// &BytesTransferred, &Overlapped); if (ERROR_HANDLE_EOF != ::GetLastError()) {
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); ret = ::GetOverlappedResult(handle, &overlapped, &bytes_read, TRUE);
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, EXPECT_FALSE(ret);
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize == EXPECT_EQ(ERROR_HANDLE_EOF, ::GetLastError());
}
EXPECT_EQ(0U, bytes_read);
EXPECT_EQ(0,
std::memcmp(write_buffer.data(), read_buffer.data(), bytes_read));
// overlapped.Offset = 0;
// ret = WriteFile(handle, Buffer[0], 2 * SystemInfo.dwPageSize,
// &BytesTransferred, &overlapped);
// ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize ==
// BytesTransferred); // BytesTransferred);
// //
// Overlapped.Offset = 0; // overlapped.Offset = 0;
// memset(AllocBuffer[1], 0, AllocBufferSize); // memset(AllocBuffer[1], 0, AllocBufferSize);
// Success = ReadFile(Handle, Buffer[1], 2 * SystemInfo.dwPageSize, // ret = ReadFile(handle, Buffer[1], 2 * SystemInfo.dwPageSize,
// &BytesTransferred, &Overlapped); // &BytesTransferred, &overlapped);
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); // ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, // ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize == // TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize ==
// BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1], // BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1],
// BytesTransferred)); // BytesTransferred));
// //
// Buffer[0] = AllocBuffer[0]; // Buffer[0] = AllocBuffer[0];
// Buffer[1] = AllocBuffer[0]; // Buffer[1] = AllocBuffer[0];
// //
// Overlapped.Offset = 0; // overlapped.Offset = 0;
// Success = WriteFile(Handle, Buffer[0], 2 * SystemInfo.dwPageSize, // ret = WriteFile(handle, Buffer[0], 2 * SystemInfo.dwPageSize,
// &BytesTransferred, &Overlapped); // &BytesTransferred, &overlapped);
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); // ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, // ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize == // TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize ==
// BytesTransferred); // BytesTransferred);
// //
// Overlapped.Offset = 0; // overlapped.Offset = 0;
// memset(AllocBuffer[1], 0, AllocBufferSize); // memset(AllocBuffer[1], 0, AllocBufferSize);
// Success = ReadFile(Handle, Buffer[1], 2 * SystemInfo.dwPageSize, // ret = ReadFile(handle, Buffer[1], 2 * SystemInfo.dwPageSize,
// &BytesTransferred, &Overlapped); // &BytesTransferred, &overlapped);
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); // ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, // ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize == // TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize ==
// BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1], // BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1],
// BytesTransferred)); // BytesTransferred));
// //
// Overlapped.Offset = 0; // overlapped.Offset = 0;
// Success = // ret =
// WriteFile(Handle, Buffer[0], 2 * SystemInfo.dwPageSize + // WriteFile(handle, Buffer[0], 2 * SystemInfo.dwPageSize +
// BytesPerSector, // bytes_per_sector,
// &BytesTransferred, &Overlapped); // &BytesTransferred, &overlapped);
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); // ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, // ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize + BytesPerSector // TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize + bytes_per_sector
// == BytesTransferred); // == BytesTransferred);
// //
// Overlapped.Offset = 0; // overlapped.Offset = 0;
// memset(AllocBuffer[1], 0, AllocBufferSize); // memset(AllocBuffer[1], 0, AllocBufferSize);
// Success = // ret =
// ReadFile(Handle, Buffer[1], 2 * SystemInfo.dwPageSize + BytesPerSector, // ReadFile(handle, Buffer[1], 2 * SystemInfo.dwPageSize +
// &BytesTransferred, &Overlapped); // bytes_per_sector,
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); // &BytesTransferred, &overlapped);
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, // ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize + BytesPerSector // ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize + bytes_per_sector
// == BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1], // == BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1],
// BytesTransferred)); // BytesTransferred));
// //
@ -408,29 +420,30 @@ static void test_overlapped_file(auto mount_location, auto &&file_path,
nullptr); nullptr);
ASSERT_NE(INVALID_HANDLE_VALUE, handle); ASSERT_NE(INVALID_HANDLE_VALUE, handle);
// Overlapped.Offset = 0; // overlapped.Offset = 0;
// memset(AllocBuffer[1], 0, AllocBufferSize); // memset(AllocBuffer[1], 0, AllocBufferSize);
// Success = // ret =
// ReadFile(Handle, Buffer[1], 2 * SystemInfo.dwPageSize + BytesPerSector, // ReadFile(handle, Buffer[1], 2 * SystemInfo.dwPageSize +
// &BytesTransferred, &Overlapped); // bytes_per_sector,
// ASSERT(Success || ERROR_IO_PENDING == GetLastError()); // &BytesTransferred, &overlapped);
// Success = GetOverlappedResult(Handle, &Overlapped, &BytesTransferred, // ASSERT(ret || ERROR_IO_PENDING == ::GetLastError());
// TRUE); ASSERT(Success); ASSERT(2 * SystemInfo.dwPageSize + BytesPerSector // ret = GetOverlappedResult(handle, &overlapped, &BytesTransferred,
// TRUE); ASSERT(ret); ASSERT(2 * SystemInfo.dwPageSize + bytes_per_sector
// == BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1], // == BytesTransferred); ASSERT(0 == memcmp(Buffer[0], Buffer[1],
// BytesTransferred)); // BytesTransferred));
// //
// Success = CloseHandle(Handle); // ret = CloseHandle(Handle);
// ASSERT(Success); // ASSERT(ret);
// //
// Handle = // handle =
// CreateFileW(FilePath, GENERIC_READ | GENERIC_WRITE, // CreateFileW(FilePath, GENERIC_READ | GENERIC_WRITE,
// FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING, 0, // FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING, 0,
// 0); // 0);
// ASSERT(INVALID_HANDLE_VALUE == Handle); // ASSERT(INVALID_HANDLE_VALUE == handle);
// ASSERT(ERROR_FILE_NOT_FOUND == GetLastError()); // ASSERT(ERROR_FILE_NOT_FOUND == ::GetLastError());
// //
// Success = CloseHandle(Overlapped.hEvent); // ret = CloseHandle(overlapped.hEvent);
// ASSERT(Success); // ASSERT(ret);
EXPECT_TRUE(::CloseHandle(handle)); EXPECT_TRUE(::CloseHandle(handle));