winfsp unit tests and fixes

repertory/repertory_test/src/winfsp_drive_create_attr_test.cpp

@@ -28,14 +28,6 @@
 //
 #include "fixtures/winfsp_fixture.hpp"
 
-// TODO revisit create_related
-// TODO revisit create_allocation
-// TODO revisit create_sd
-// TODO revisit create_notraverse
-// TODO revisit create_backup
-// TODO revisit create_restore
-// TODO revisit create_share
-
 namespace repertory {
 TYPED_TEST_CASE(winfsp_test, winfsp_provider_types);
 
@@ -47,7 +39,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_new_file_with_normal_attribute) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -64,7 +56,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_new_file_with_read_only_attribute) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_READONLY, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -84,7 +76,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_new_file_with_read_only_attribute) {
 //   GENERIC_WRITE,
 //                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
 //                               CREATE_NEW, FILE_ATTRIBUTE_SYSTEM, 0);
-//   EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+//   ASSERT_NE(INVALID_HANDLE_VALUE, handle);
 //   ::CloseHandle(handle);
 //
 //   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -104,7 +96,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_new_file_with_hidden_attribute) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_HIDDEN, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -123,7 +115,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_always_file_with_normal_attribute) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
                               CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -138,7 +130,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_file_with_read_only_attribute) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
                               CREATE_ALWAYS, FILE_ATTRIBUTE_READONLY, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -157,7 +149,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_file_with_read_only_attribute) {
 //   GENERIC_WRITE,
 //                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
 //                               CREATE_ALWAYS, FILE_ATTRIBUTE_SYSTEM, 0);
-//   EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+//   ASSERT_NE(INVALID_HANDLE_VALUE, handle);
 //   ::CloseHandle(handle);
 //
 //   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -175,7 +167,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_create_always_file_with_hidden_attribute) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
                               CREATE_ALWAYS, FILE_ATTRIBUTE_HIDDEN, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   auto attr = ::GetFileAttributesA(file_path.c_str());
@@ -204,7 +196,7 @@ TYPED_TEST(winfsp_test, cr8_attr_can_handle_read_only_directory) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   EXPECT_TRUE(::DeleteFileA(file_path.c_str()));

repertory/repertory_test/src/winfsp_drive_create_nl_test.cpp

@@ -47,7 +47,7 @@ TYPED_TEST(winfsp_test, cr8_nl_can_create_file_of_max_component_length) {
         ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                       FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                       FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0);
-    EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+    ASSERT_NE(INVALID_HANDLE_VALUE, handle);
     EXPECT_TRUE(::CloseHandle(handle));
   }
 }
@@ -70,7 +70,7 @@ TYPED_TEST(winfsp_test,
         ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                       FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                       FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0);
-    EXPECT_EQ(INVALID_HANDLE_VALUE, handle);
+    ASSERT_EQ(INVALID_HANDLE_VALUE, handle);
     EXPECT_EQ(ERROR_INVALID_NAME, ::GetLastError());
   }
 }

repertory/repertory_test/src/winfsp_drive_create_test.cpp

@@ -37,7 +37,7 @@ TYPED_TEST(winfsp_test, cr8_file_can_create_file) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 }
 
@@ -48,7 +48,7 @@ TYPED_TEST(winfsp_test, cr8_file_create_new_fails_when_file_exists) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_EQ(INVALID_HANDLE_VALUE, handle);
+  ASSERT_EQ(INVALID_HANDLE_VALUE, handle);
   EXPECT_EQ(ERROR_FILE_EXISTS, ::GetLastError());
 }
 
@@ -59,7 +59,7 @@ TYPED_TEST(winfsp_test, cr8_file_can_open_existing_file) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
                               OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 }
 
@@ -70,7 +70,7 @@ TYPED_TEST(winfsp_test, cr8_file_create_always_succeeds_when_file_exists) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
                               CREATE_ALWAYS, FILE_ATTRIBUTE_HIDDEN, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   // EXPECT file_size is 0
   ::CloseHandle(handle);
 }
@@ -82,13 +82,13 @@ TYPED_TEST(winfsp_test, cr8_file_can_delete_file_after_close) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
                               OPEN_EXISTING, FILE_FLAG_DELETE_ON_CLOSE, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                          FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING,
                          FILE_FLAG_DELETE_ON_CLOSE, 0);
-  EXPECT_EQ(INVALID_HANDLE_VALUE, handle);
+  ASSERT_EQ(INVALID_HANDLE_VALUE, handle);
   EXPECT_EQ(ERROR_FILE_NOT_FOUND, ::GetLastError());
 
   // EXPECT file not found
@@ -103,7 +103,7 @@ TYPED_TEST(winfsp_test,
         (this->mount_location + "\\" + invalid_char + "\\test_file_0").c_str(),
         GENERIC_READ | GENERIC_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE, 0,
         CREATE_NEW, FILE_ATTRIBUTE_NORMAL, 0);
-    EXPECT_EQ(INVALID_HANDLE_VALUE, handle);
+    ASSERT_EQ(INVALID_HANDLE_VALUE, handle);
     if (handle != INVALID_HANDLE_VALUE) {
       std::cout << "char: " << invalid_char << std::endl;
     }
@@ -123,7 +123,7 @@ TYPED_TEST(winfsp_test,
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_EQ(INVALID_HANDLE_VALUE, handle);
+  ASSERT_EQ(INVALID_HANDLE_VALUE, handle);
   EXPECT_EQ(ERROR_INVALID_NAME, ::GetLastError());
 }
 
@@ -155,34 +155,34 @@ TYPED_TEST(winfsp_test, cr8_file_directory_delete_fails_if_not_empty) {
   auto handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                               FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
                               FILE_ATTRIBUTE_NORMAL, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   handle =
       ::CreateFileA(dir_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                     FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING,
                     FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_DELETE_ON_CLOSE, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   handle = ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                          FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING,
                          FILE_FLAG_DELETE_ON_CLOSE, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   handle =
       ::CreateFileA(dir_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                     FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING,
                     FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_DELETE_ON_CLOSE, 0);
-  EXPECT_NE(INVALID_HANDLE_VALUE, handle);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
   ::CloseHandle(handle);
 
   handle =
       ::CreateFileA(dir_path.c_str(), GENERIC_READ | GENERIC_WRITE,
                     FILE_SHARE_READ | FILE_SHARE_WRITE, 0, OPEN_EXISTING,
                     FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_DELETE_ON_CLOSE, 0);
-  EXPECT_EQ(INVALID_HANDLE_VALUE, handle);
+  ASSERT_EQ(INVALID_HANDLE_VALUE, handle);
   EXPECT_EQ(ERROR_FILE_NOT_FOUND, ::GetLastError());
 }
 } // namespace repertory

repertory/repertory_test/src/winfsp_drive_info_test.cpp

@@ -0,0 +1,86 @@
+/*
+  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+
+  Permission is hereby granted, free of charge, to any person obtaining a copy
+  of this software and associated documentation files (the "Software"), to deal
+  in the Software without restriction, including without limitation the rights
+  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+  copies of the Software, and to permit persons to whom the Software is
+  furnished to do so, subject to the following conditions:
+
+  The above copyright notice and this permission notice shall be included in all
+  copies or substantial portions of the Software.
+
+  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+  SOFTWARE.
+*/
+#if defined(_WIN32)
+
+//
+// Implemented test cases based on WinFsp tests:
+// https://github.com/winfsp/winfsp/blob/v2.0/tst/winfsp-tests
+//
+#include "fixtures/winfsp_fixture.hpp"
+
+namespace repertory {
+TYPED_TEST_CASE(winfsp_test, winfsp_provider_types);
+
+TYPED_TEST(winfsp_test, info_can_get_tag_info) {
+  auto file_path{
+      utils::path::combine(this->mount_location, {"test_file_2"}),
+  };
+  auto handle =
+      ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
+                    FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
+                    FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
+
+  FILE_ATTRIBUTE_TAG_INFO tag_info{};
+  EXPECT_TRUE(::GetFileInformationByHandleEx(handle, FileAttributeTagInfo,
+                                             &tag_info, sizeof tag_info));
+  EXPECT_EQ(FILE_ATTRIBUTE_ARCHIVE, tag_info.FileAttributes);
+  EXPECT_EQ(0, tag_info.ReparseTag);
+
+  ::CloseHandle(handle);
+}
+
+TYPED_TEST(winfsp_test, info_can_get_basic_info) {
+  FILETIME file_time{};
+  ::GetSystemTimeAsFileTime(&file_time);
+
+  auto time_low = ((PLARGE_INTEGER)&file_time)->QuadPart;
+  auto time_high = time_low + 10000 * 10000 /* 10 seconds */;
+
+  auto file_path{
+      utils::path::combine(this->mount_location, {"test_file_2"}),
+  };
+  auto handle =
+      ::CreateFileA(file_path.c_str(), GENERIC_READ | GENERIC_WRITE,
+                    FILE_SHARE_READ | FILE_SHARE_WRITE, 0, CREATE_NEW,
+                    FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0);
+  ASSERT_NE(INVALID_HANDLE_VALUE, handle);
+
+  FILE_BASIC_INFO basic_info{};
+  EXPECT_TRUE(::GetFileInformationByHandleEx(handle, FileBasicInfo, &basic_info,
+                                             sizeof basic_info));
+  EXPECT_EQ(FILE_ATTRIBUTE_ARCHIVE, basic_info.FileAttributes);
+  EXPECT_LE(time_low, basic_info.CreationTime.QuadPart);
+  EXPECT_GT(time_high, basic_info.CreationTime.QuadPart);
+
+  EXPECT_LE(time_low, basic_info.LastAccessTime.QuadPart);
+  EXPECT_GT(time_high, basic_info.LastAccessTime.QuadPart);
+  EXPECT_LE(time_low, basic_info.LastWriteTime.QuadPart);
+  EXPECT_GT(time_high, basic_info.LastWriteTime.QuadPart);
+  EXPECT_LE(time_low, basic_info.ChangeTime.QuadPart);
+  EXPECT_GT(time_high, basic_info.ChangeTime.QuadPart);
+
+  ::CloseHandle(handle);
+}
+} // namespace repertory
+
+#endif // defined(_WIN32)

repertory/repertory_test/src/winfsp_drive_test.cpp

@@ -21,6 +21,15 @@
 */
 #if defined(_WIN32)
 
+// TODO revisit create_related
+// TODO revisit create_allocation
+// TODO revisit create_sd
+// TODO revisit create_notraverse
+// TODO revisit create_backup
+// TODO revisit create_restore
+// TODO revisit create_share
+// TODO revisit getfileattr_test
+
 //
 // Implemented test cases based on WinFsp tests:
 // https://github.com/winfsp/winfsp/blob/v2.0/tst/winfsp-tests