From 49e518ac1923deb19386dae5fb656c79b91375ee Mon Sep 17 00:00:00 2001 From: "Scott E. Graves" Date: Tue, 22 Oct 2024 13:10:01 -0500 Subject: [PATCH] refactor --- .../include/mocks/mock_winfsp_drive.hpp | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/repertory/repertory_test/include/mocks/mock_winfsp_drive.hpp b/repertory/repertory_test/include/mocks/mock_winfsp_drive.hpp index d559d5fa..e30c3c1f 100644 --- a/repertory/repertory_test/include/mocks/mock_winfsp_drive.hpp +++ b/repertory/repertory_test/include/mocks/mock_winfsp_drive.hpp @@ -143,11 +143,12 @@ public: FILE_FLAG_BACKUP_SEMANTICS | (directory ? FILE_ATTRIBUTE_DIRECTORY : FILE_ATTRIBUTE_NORMAL); auto share_mode = FILE_SHARE_READ | FILE_SHARE_WRITE; - auto handle = - ::CreateFileA(file_path.c_str(), GENERIC_READ, share_mode, nullptr, - OPEN_EXISTING, static_cast(attributes), nullptr); - FILE_BASIC_INFO fi{}; - ::GetFileInformationByHandleEx(handle, FileBasicInfo, &fi, sizeof(fi)); + auto handle = ::CreateFileA( + file_path.c_str(), GENERIC_READ, static_cast(share_mode), + nullptr, OPEN_EXISTING, static_cast(attributes), nullptr); + FILE_BASIC_INFO basic_info{}; + ::GetFileInformationByHandleEx(handle, FileBasicInfo, &basic_info, + sizeof(basic_info)); if (not directory) { auto opt_size = utils::file::file{file_path}.size(); if (not opt_size.has_value()) { @@ -162,11 +163,14 @@ public: : utils::divide_with_ceiling(file_info.FileSize, WINFSP_ALLOCATION_UNIT) * WINFSP_ALLOCATION_UNIT; - file_info.FileAttributes = fi.FileAttributes; - file_info.ChangeTime = static_cast(fi.ChangeTime.QuadPart); - file_info.CreationTime = static_cast(fi.CreationTime.QuadPart); - file_info.LastAccessTime = static_cast(fi.LastAccessTime.QuadPart); - file_info.LastWriteTime = static_cast(fi.LastWriteTime.QuadPart); + file_info.FileAttributes = basic_info.FileAttributes; + file_info.ChangeTime = static_cast(basic_info.ChangeTime.QuadPart); + file_info.CreationTime = + static_cast(basic_info.CreationTime.QuadPart); + file_info.LastAccessTime = + static_cast(basic_info.LastAccessTime.QuadPart); + file_info.LastWriteTime = + static_cast(basic_info.LastWriteTime.QuadPart); ::CloseHandle(handle); return api_error::success; }