From 5fcb182cb853a83fe6f7c194a211e6d9a9373531 Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Mon, 16 Dec 2024 10:24:05 -0600
Subject: [PATCH] refactor

---
 .../librepertory/src/comm/packet/packet_client.cpp     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/repertory/librepertory/src/comm/packet/packet_client.cpp b/repertory/librepertory/src/comm/packet/packet_client.cpp
index f87b5258..faf5616b 100644
--- a/repertory/librepertory/src/comm/packet/packet_client.cpp
+++ b/repertory/librepertory/src/comm/packet/packet_client.cpp
@@ -109,7 +109,7 @@ auto packet_client::get_client() -> std::shared_ptr<packet_client::client> {
   }
 
   auto cli = clients_.at(0U);
-  utils::collection::remove_element(clients_, cli);
+  utils::collection::remove_element(clients_, ret);
   return cli;
 }
 
@@ -126,7 +126,7 @@ auto packet_client::read_packet(client &cli, packet &response)
   const auto read_buffer = [&]() {
     std::uint32_t offset{};
     while (offset < buffer.size()) {
-      const auto bytes_read = boost::asio::read(
+      auto bytes_read = boost::asio::read(
           cli.socket,
           boost::asio::buffer(&buffer[offset], buffer.size() - offset));
       if (bytes_read <= 0) {
@@ -137,7 +137,7 @@ auto packet_client::read_packet(client &cli, packet &response)
   };
   read_buffer();
 
-  const auto size = boost::endian::big_to_native(
+  auto size = boost::endian::big_to_native(
       *reinterpret_cast<std::uint32_t *>(buffer.data()));
   buffer.resize(size);
 
@@ -186,7 +186,7 @@ auto packet_client::send(std::string_view method, packet &request,
   request.encode_top(PACKET_SERVICE_FLAGS);
   request.encode_top(std::string{project_get_version()});
 
-  static const std::uint8_t max_attempts{5U};
+  static contexpr const std::uint8_t max_attempts{5U};
   for (std::uint8_t i = 1U;
        allow_connections_ && not success && (i <= max_attempts); i++) {
     auto current_client = get_client();
@@ -205,7 +205,7 @@ auto packet_client::send(std::string_view method, packet &request,
 
         std::uint32_t offset{};
         while (offset < request.get_size()) {
-          const auto bytes_written = boost::asio::write(
+          auto bytes_written = boost::asio::write(
               current_client->socket,
               boost::asio::buffer(&request[offset],
                                   request.get_size() - offset));