From 6fc008529291f2bbdd61f8348bceb50ed59b248c Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Mon, 16 Dec 2024 10:22:49 -0600
Subject: [PATCH] refactor

---
 .../src/comm/packet/packet_client.cpp            | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/repertory/librepertory/src/comm/packet/packet_client.cpp b/repertory/librepertory/src/comm/packet/packet_client.cpp
index 47bf8998..f87b5258 100644
--- a/repertory/librepertory/src/comm/packet/packet_client.cpp
+++ b/repertory/librepertory/src/comm/packet/packet_client.cpp
@@ -95,24 +95,22 @@ void packet_client::connect(client &cli) {
 }
 
 auto packet_client::get_client() -> std::shared_ptr<packet_client::client> {
-  std::shared_ptr<client> ret;
-
   unique_mutex_lock clients_lock(clients_mutex_);
   if (not allow_connections_) {
-    return ret;
+    return nullptr;
   }
 
   if (clients_.empty()) {
     clients_lock.unlock();
 
-    ret = std::make_shared<client>(io_context_);
-    connect(*ret);
-    return ret;
+    auto cli = std::make_shared<client>(io_context_);
+    connect(*cli);
+    return cli;
   }
 
-  ret = clients_.at(0U);
-  utils::collection::remove_element(clients_, ret);
-  return ret;
+  auto cli = clients_.at(0U);
+  utils::collection::remove_element(clients_, cli);
+  return cli;
 }
 
 void packet_client::put_client(std::shared_ptr<client> &cli) {