From 9875701f96a9b3f18655775f3789e71f10713567 Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Wed, 17 Sep 2025 10:52:52 -0500
Subject: [PATCH] [unit test] Complete all providers unit tests #12

---
 .../repertory_test/src/providers_test.cpp     | 27 +++++++------------
 1 file changed, 9 insertions(+), 18 deletions(-)

diff --git a/repertory/repertory_test/src/providers_test.cpp b/repertory/repertory_test/src/providers_test.cpp
index 946fe069..82a4a880 100644
--- a/repertory/repertory_test/src/providers_test.cpp
+++ b/repertory/repertory_test/src/providers_test.cpp
@@ -1139,8 +1139,7 @@ static void get_pinned_files(i_provider &provider) {
                app_config::get_provider_name(provider.get_provider_type()),
                __FUNCTION__);
   if (provider.is_read_only()) {
-    api_file_list pinned{};
-    EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+    auto pinned= provider.get_pinned_files());
     EXPECT_TRUE(pinned.empty());
     return;
   }
@@ -1156,8 +1155,7 @@ static void get_pinned_files(i_provider &provider) {
   EXPECT_EQ(api_error::success,
             provider.set_item_meta("/nopin01.txt", META_PINNED, "false"));
 
-  api_file_list pinned{};
-  EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+  auto pinned = provider.get_pinned_files(pinned);
   EXPECT_EQ(std::size_t(2U), pinned.size());
 
   const auto has_path = [&](std::string_view path) {
@@ -1180,8 +1178,7 @@ static void remove_pin_updates_pinned_files(i_provider &provider) {
                __FUNCTION__);
 
   if (provider.is_read_only()) {
-    api_file_list pinned{};
-    EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+    auto pinned = provider.get_pinned_files();
     EXPECT_TRUE(pinned.empty());
     return;
   }
@@ -1193,8 +1190,7 @@ static void remove_pin_updates_pinned_files(i_provider &provider) {
   EXPECT_EQ(api_error::success,
             provider.set_item_meta("/pin02.txt", META_PINNED, "true"));
 
-  api_file_list pinned{};
-  EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+  auto pinned = provider.get_pinned_files();
   EXPECT_EQ(std::size_t(2U), pinned.size());
 
   const auto has_path = [&](std::string_view path) {
@@ -1204,16 +1200,14 @@ static void remove_pin_updates_pinned_files(i_provider &provider) {
 
   EXPECT_EQ(api_error::success,
             provider.set_item_meta("/pin02.txt", META_PINNED, "false"));
-  pinned.clear();
-  EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+  pinned = provider.get_pinned_files();
   EXPECT_EQ(std::size_t(1U), pinned.size());
   EXPECT_TRUE(has_path("/pin01.txt"));
   EXPECT_FALSE(has_path("/pin02.txt"));
 
   EXPECT_EQ(api_error::success,
             provider.set_item_meta("/pin01.txt", META_PINNED, "false"));
-  pinned.clear();
-  EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+  pinned = provider.get_pinned_files();
   EXPECT_TRUE(pinned.empty());
 
   EXPECT_EQ(api_error::success, provider.remove_file("/pin01.txt"));
@@ -1226,8 +1220,7 @@ static void remove_file_updates_pinned_files(i_provider &provider) {
                __FUNCTION__);
 
   if (provider.is_read_only()) {
-    api_file_list pinned{};
-    EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+    auto pinned = provider.get_pinned_files();
     EXPECT_TRUE(pinned.empty());
     return;
   }
@@ -1243,8 +1236,7 @@ static void remove_file_updates_pinned_files(i_provider &provider) {
   EXPECT_EQ(api_error::success,
             provider.set_item_meta("/nopin.txt", META_PINNED, "false"));
 
-  api_file_list pinned{};
-  EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+  auto pinned = provider.get_pinned_files();
   EXPECT_EQ(std::size_t(2U), pinned.size());
 
   const auto has_path = [&](std::string_view path) {
@@ -1258,8 +1250,7 @@ static void remove_file_updates_pinned_files(i_provider &provider) {
 
   EXPECT_EQ(api_error::success, provider.remove_file("/pin_delete.txt"));
 
-  pinned.clear();
-  EXPECT_EQ(api_error::success, provider.get_pinned_files(pinned));
+  pinned = provider.get_pinned_files();
   EXPECT_EQ(std::size_t(1U), pinned.size());
   EXPECT_TRUE(has_path("/pin_keep.txt"));
   EXPECT_FALSE(has_path("/pin_delete.txt"));