BlockStorage/repertory
1
0
Fork 0
Code Issues 7 Pull Requests Releases 6 Wiki Activity

[bug] Windows-to-Linux remote mount is allowing directory rename when directory is not empty #47

Browse Source
This commit is contained in:
Scott E. Graves 2025-04-15 09:27:00 -05:00
parent a4d53c1011
commit a2b8998f4a
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
repertory/librepertory/src/drives/fuse/remotefuse/remote_server.cpp
View File

@ -1448,15 +1448,22 @@ auto remote_server::winfsp_rename(PVOID /*file_desc*/, PWSTR file_name,
ret = ((res < 0) ? static_cast<packet::error_type>(
utils::unix_error_to_windows(errno))
: 0);
} else if (utils::file::directory(file_path).exists()) {
} else {
auto dir{utils::file::directory(file_path)};
if (dir.exists()) {
if (dir.count(false) == 0U) {
res = drive_.rename_directory(construct_api_path(file_path),
construct_api_path(new_file_path));
ret =
((res < 0) ? errno == EISDIR
ret = ((res < 0)
? errno == EISDIR
? static_cast<packet::error_type>(STATUS_ACCESS_DENIED)
: static_cast<packet::error_type>(
utils::unix_error_to_windows(errno))
: 0);
} else {
ret = static_cast<packet::error_type>(STATUS_DIRECTORY_NOT_EMPTY);
}
}
}
RAISE_REMOTE_FUSE_SERVER_EVENT(function_name, file_path + "|" + new_file_path,