From a6bfd2306c2acab3e20fecca77c17ab822c31b75 Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Thu, 19 Dec 2024 14:22:13 -0600
Subject: [PATCH] fix

---
 repertory/librepertory/include/app_config.hpp | 7 +++----
 repertory/librepertory/src/app_config.cpp     | 9 +++------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/repertory/librepertory/include/app_config.hpp b/repertory/librepertory/include/app_config.hpp
index e606bf3f..f3d9aa85 100644
--- a/repertory/librepertory/include/app_config.hpp
+++ b/repertory/librepertory/include/app_config.hpp
@@ -83,7 +83,7 @@ private:
   std::atomic<std::uint8_t> min_download_timeout_secs_;
   std::atomic<std::uint16_t> online_check_retry_secs_;
   std::atomic<std::uint16_t> orphaned_file_retention_days_;
-  atomic<std::string> preferred_download_type_;
+  atomic<download_type> preferred_download_type_;
   std::atomic<std::uint8_t> remote_client_pool_size_;
   std::atomic<std::uint16_t> remote_api_port_;
   atomic<std::string> remote_encryption_token_;
@@ -245,8 +245,7 @@ public:
   }
 
   [[nodiscard]] auto get_preferred_download_type() const -> download_type {
-    return download_type_from_string(preferred_download_type_,
-                                     download_type::fallback);
+    return preferred_download_type_;
   }
 
   [[nodiscard]] auto get_provider_type() const -> provider_type {
@@ -390,7 +389,7 @@ public:
   }
 
   void set_preferred_download_type(const download_type &type) {
-    set_value(preferred_download_type_, download_type_to_string(type));
+    set_value(preferred_download_type_, type);
   }
 
   void set_remote_client_pool_size(std::uint8_t remote_client_pool_size) {
diff --git a/repertory/librepertory/src/app_config.cpp b/repertory/librepertory/src/app_config.cpp
index 76dcf776..c53eb1fb 100644
--- a/repertory/librepertory/src/app_config.cpp
+++ b/repertory/librepertory/src/app_config.cpp
@@ -83,8 +83,7 @@ app_config::app_config(const provider_type &prov,
       min_download_timeout_secs_(default_min_download_timeout_secs),
       online_check_retry_secs_(default_online_check_retry_secs),
       orphaned_file_retention_days_(default_orphaned_file_retention_days),
-      preferred_download_type_(
-          download_type_to_string(download_type::fallback)),
+      preferred_download_type_(download_type::fallback),
       remote_client_pool_size_(default_remote_client_pool_size),
       remote_api_port_(default_remote_api_port(prov)),
       remote_encryption_token_(default_remote_encryption_token),
@@ -413,8 +412,7 @@ auto app_config::get_value_by_name(const std::string &name) const
       return std::to_string(get_orphaned_file_retention_days());
     }
     if (name == "PreferredDownloadType") {
-      return download_type_to_string(download_type_from_string(
-          preferred_download_type_, download_type::fallback));
+      return download_type_to_string(get_preferred_download_type());
     }
     if (name == "RemoteConfig.ApiPort") {
       return std::to_string(get_remote_config().api_port);
@@ -789,8 +787,7 @@ auto app_config::set_value_by_name(const std::string &name,
       return std::to_string(get_orphaned_file_retention_days());
     }
     if (name == "PreferredDownloadType") {
-      set_preferred_download_type(
-          download_type_from_string(value, download_type::fallback));
+      set_preferred_download_type(download_type_from_string(value));
       return download_type_to_string(get_preferred_download_type());
     }
     if (name == "RemoteConfig.ApiPort") {