From ca7257d7f7bb86d318ede2ca2ed32714cd4bbf8c Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Sat, 21 Dec 2024 17:33:35 -0600
Subject: [PATCH] unit tests and fixes

---
 .../librepertory/include/types/repertory.hpp  | 20 ++++++
 repertory/repertory_test/src/atomic_test.cpp  |  5 ++
 .../src/json_serialize_test.cpp               | 62 +++++++++++++++++++
 3 files changed, 87 insertions(+)

diff --git a/repertory/librepertory/include/types/repertory.hpp b/repertory/librepertory/include/types/repertory.hpp
index 8ae7b64c..36f40576 100644
--- a/repertory/librepertory/include/types/repertory.hpp
+++ b/repertory/librepertory/include/types/repertory.hpp
@@ -629,6 +629,26 @@ template <> struct adl_serializer<std::atomic<repertory::download_type>> {
     value.store(repertory::download_type_from_string(data.get<std::string>()));
   }
 };
+
+template <> struct adl_serializer<repertory::database_type> {
+  static void to_json(json &data, const repertory::database_type &value) {
+    data = repertory::database_type_to_string(value);
+  }
+
+  static void from_json(const json &data, repertory::database_type &value) {
+    value = repertory::database_type_from_string(data.get<std::string>());
+  }
+};
+
+template <> struct adl_serializer<repertory::download_type> {
+  static void to_json(json &data, const repertory::download_type &value) {
+    data = repertory::download_type_to_string(value);
+  }
+
+  static void from_json(const json &data, repertory::download_type &value) {
+    value = repertory::download_type_from_string(data.get<std::string>());
+  }
+};
 NLOHMANN_JSON_NAMESPACE_END
 
 #endif // REPERTORY_INCLUDE_TYPES_REPERTORY_HPP_
diff --git a/repertory/repertory_test/src/atomic_test.cpp b/repertory/repertory_test/src/atomic_test.cpp
index 809fd743..ef782f88 100644
--- a/repertory/repertory_test/src/atomic_test.cpp
+++ b/repertory/repertory_test/src/atomic_test.cpp
@@ -28,6 +28,11 @@ TEST(atomic, atomic_primitive) {
   atomic<std::uint16_t> value;
   value = 5U;
   EXPECT_EQ(5U, static_cast<std::uint16_t>(value));
+  EXPECT_EQ(5U, value.load());
+
+  value.store(6U);
+  EXPECT_EQ(6U, static_cast<std::uint16_t>(value));
+  EXPECT_EQ(6U, value.load());
 }
 
 TEST(atomic, atomic_primitive_equality) {
diff --git a/repertory/repertory_test/src/json_serialize_test.cpp b/repertory/repertory_test/src/json_serialize_test.cpp
index f80715a6..242f35c2 100644
--- a/repertory/repertory_test/src/json_serialize_test.cpp
+++ b/repertory/repertory_test/src/json_serialize_test.cpp
@@ -183,4 +183,66 @@ TEST(json_serialize, can_handle_sia_config) {
     EXPECT_STREQ(cfg2.bucket.c_str(), cfg.bucket.c_str());
   }
 }
+
+TEST(json_serialize, can_handle_atomic) {
+  atomic<sia_config> cfg({
+      "bucket",
+  });
+
+  json data(cfg);
+  EXPECT_STREQ("bucket", data.at(JSON_BUCKET).get<std::string>().c_str());
+
+  {
+    auto cfg2 = data.get<atomic<sia_config>>();
+    EXPECT_STREQ(cfg2.load().bucket.c_str(), cfg.load().bucket.c_str());
+  }
+}
+
+TEST(json_serialize, can_handle_database_type) {
+  json data(database_type::rocksdb);
+  EXPECT_EQ(database_type::rocksdb, data.get<database_type>());
+  EXPECT_STREQ("rocksdb", data.get<std::string>().c_str());
+
+  data = database_type::sqlite;
+  EXPECT_EQ(database_type::sqlite, data.get<database_type>());
+  EXPECT_STREQ("sqlite", data.get<std::string>().c_str());
+}
+
+TEST(json_serialize, can_handle_download_type) {
+  json data(download_type::direct);
+  EXPECT_EQ(download_type::direct, data.get<download_type>());
+  EXPECT_STREQ("direct", data.get<std::string>().c_str());
+
+  data = download_type::fallback;
+  EXPECT_EQ(download_type::fallback, data.get<download_type>());
+  EXPECT_STREQ("fallback", data.get<std::string>().c_str());
+
+  data = download_type::ring_buffer;
+  EXPECT_EQ(download_type::ring_buffer, data.get<download_type>());
+  EXPECT_STREQ("ring_buffer", data.get<std::string>().c_str());
+}
+
+TEST(json_serialize, can_handle_atomic_database_type) {
+  json data(atomic<database_type>{database_type::rocksdb});
+  EXPECT_EQ(database_type::rocksdb, data.get<atomic<database_type>>());
+  EXPECT_STREQ("rocksdb", data.get<std::string>().c_str());
+
+  data = atomic<database_type>(database_type::sqlite);
+  EXPECT_EQ(database_type::sqlite, data.get<atomic<database_type>>());
+  EXPECT_STREQ("sqlite", data.get<std::string>().c_str());
+}
+
+TEST(json_serialize, can_handle_atomic_download_type) {
+  json data(atomic<download_type>{download_type::direct});
+  EXPECT_EQ(download_type::direct, data.get<atomic<download_type>>());
+  EXPECT_STREQ("direct", data.get<std::string>().c_str());
+
+  data = atomic<download_type>{download_type::fallback};
+  EXPECT_EQ(download_type::fallback, data.get<download_type>());
+  EXPECT_STREQ("fallback", data.get<std::string>().c_str());
+
+  data = atomic<download_type>{download_type::ring_buffer};
+  EXPECT_EQ(download_type::ring_buffer, data.get<atomic<download_type>>());
+  EXPECT_STREQ("ring_buffer", data.get<std::string>().c_str());
+}
 } // namespace repertory