From ceda21830fe24a7ec323952251cfcf3bfb0ee2af Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Tue, 24 Sep 2024 07:30:18 -0500
Subject: [PATCH] refactor

---
 .../src/providers/base_provider.cpp           | 29 +++++++++----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/repertory/librepertory/src/providers/base_provider.cpp b/repertory/librepertory/src/providers/base_provider.cpp
index 08425405..21f001ee 100644
--- a/repertory/librepertory/src/providers/base_provider.cpp
+++ b/repertory/librepertory/src/providers/base_provider.cpp
@@ -445,9 +445,8 @@ void base_provider::remove_deleted_files(bool source_only) {
         utils::file::directory{config_.get_cache_directory()}.get_files();
     for (auto &&source_file : source_list) {
       filesystem_item fsi{};
-      auto sp_res =
-          get_filesystem_item_from_source_path(source_file->get_path(), fsi);
-      if (sp_res != api_error::item_not_found) {
+      if (get_filesystem_item_from_source_path(source_file->get_path(), fsi) !=
+          api_error::item_not_found) {
         continue;
       }
 
@@ -527,18 +526,19 @@ void base_provider::remove_deleted_files(bool source_only) {
     removed_list.emplace_back(removed_item{api_path, false, meta[META_SOURCE]});
   }
 
+  const auto orphaned_directory =
+      utils::path::combine(config_.get_data_directory(), {"orphaned"});
+
   for (auto &&item : removed_list) {
     if (item.directory) {
       continue;
     }
 
-    if (not utils::file::file(item.source_path).exists()) {
+    if (not utils::file::file{item.source_path}.exists()) {
       continue;
     }
 
-    const auto orphaned_directory =
-        utils::path::combine(config_.get_data_directory(), {"orphaned"});
-    if (not utils::file::directory(orphaned_directory).create_directory()) {
+    if (not utils::file::directory{orphaned_directory}.create_directory()) {
       utils::error::raise_error(
           function_name, std::to_string(utils::get_last_error_code()),
           "failed to create orphaned directory|sp|" + orphaned_directory);
@@ -714,16 +714,15 @@ auto base_provider::start(api_item_added_callback api_item_added,
     }
   }
 
-  if (online && not unmount_requested) {
-    remove_deleted_files(true);
-
-    polling::instance().set_callback(
-        {"check_deleted", polling::frequency::low,
-         [this]() { remove_deleted_files(false); }});
-    return true;
+  if (not online || unmount_requested) {
+    return false;
   }
 
-  return false;
+  remove_deleted_files(true);
+
+  polling::instance().set_callback({"check_deleted", polling::frequency::low,
+                                    [this]() { remove_deleted_files(false); }});
+  return true;
 }
 
 void base_provider::stop() {