v2.0.3-rc (#32)

# Changelog

## v2.0.3-rc

### Issues

* \#28 \[bug\] Address slow directory responses in S3 mounts for deeply nested directories
* \#29 \[bug\] S3 error responses are not being logged
* \#30 \[bug\] Sia provider error responses are not logged
* \#31 \[bug\] S3 provider should limit max key size to 1024

### Changes from v2.0.2-rc

* Always use direct for read-only providers
* Fixed externally removed files not being processed during cleanup
* Fixed http headers not being added for requests
* Fixed incorrect `stat` values for remote mounts
* Fixed invalid directory nullptr error on remote mounts
* Fixed memory leak in event system
* Refactored application shutdown
* Refactored event system
* Updated build system to Alpine 3.21.0
* Updated build system to MinGW-w64 12.0.0
* Updated copyright to 2018-2025

Reviewed-on: #32

repertory/librepertory/include/utils/cli_utils.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal

repertory/librepertory/include/utils/error_utils.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal

repertory/librepertory/include/utils/file_utils.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal

repertory/librepertory/include/utils/polling.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
@@ -40,7 +40,7 @@ public:
   struct polling_item final {
     std::string name;
     frequency freq;
-    std::function<void(const stop_type &stop_requested)> action;
+    std::function<void(stop_type &stop_requested)> action;
   };
 
 public:
@@ -75,6 +75,8 @@ private:
   void frequency_thread(std::function<std::uint32_t()> get_frequency_seconds,
                         frequency freq);
 
+  [[nodiscard]] auto get_stop_requested() const -> bool;
+
 public:
   void remove_callback(const std::string &name);
 

repertory/librepertory/include/utils/single_thread_service_base.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
@@ -36,7 +36,7 @@ private:
   const std::string service_name_;
   mutable std::mutex mtx_;
   mutable std::condition_variable notify_;
-  stop_type stop_requested_ = false;
+  stop_type stop_requested_{false};
   std::unique_ptr<std::thread> thread_;
 
 protected:
@@ -46,9 +46,7 @@ protected:
     return notify_;
   }
 
-  [[nodiscard]] auto get_stop_requested() const -> bool {
-    return stop_requested_;
-  }
+  [[nodiscard]] auto get_stop_requested() const -> bool;
 
   void notify_all() const;
 

repertory/librepertory/include/utils/tasks.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
@@ -30,7 +30,7 @@ class app_config;
 class tasks final {
 public:
   struct task final {
-    std::function<void(const stop_type &task_stopped)> action;
+    std::function<void(stop_type &task_stopped)> action;
   };
 
   class i_task {
@@ -104,6 +104,8 @@ private:
 private:
   void task_thread();
 
+  [[nodiscard]] auto get_stop_requested() const -> bool;
+
 public:
   auto schedule(task item) -> task_ptr;
 

repertory/librepertory/include/utils/throttle.hpp

@@ -1,59 +0,0 @@
-/*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-#ifndef REPERTORY_INCLUDE_UTILS_THROTTLE_HPP_
-#define REPERTORY_INCLUDE_UTILS_THROTTLE_HPP_
-
-namespace repertory {
-class throttle final {
-public:
-  throttle() : max_size_(10u) {}
-
-  explicit throttle(std::size_t max_size) : max_size_(max_size) {}
-
-public:
-  throttle(const throttle &) noexcept = delete;
-  throttle(throttle &&) noexcept = delete;
-  auto operator=(const throttle &) -> throttle & = delete;
-  auto operator=(throttle &&) -> throttle & = delete;
-
-public:
-  ~throttle() { shutdown(); }
-
-private:
-  const std::size_t max_size_;
-  std::size_t count_ = 0u;
-  bool shutdown_ = false;
-  std::mutex mutex_;
-  std::condition_variable notify_;
-
-public:
-  void decrement();
-
-  void increment_or_wait();
-
-  void reset();
-
-  void shutdown();
-};
-} // namespace repertory
-
-#endif // REPERTORY_INCLUDE_UTILS_THROTTLE_HPP_

repertory/librepertory/include/utils/timeout.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
@@ -32,13 +32,13 @@ public:
 
 public:
   timeout(std::function<void()> timeout_callback,
-          const std::chrono::system_clock::duration &duration = 10s);
+          std::chrono::system_clock::duration duration);
 
   ~timeout() { disable(); }
 
 private:
-  bool timeout_killed_;
-  std::unique_ptr<std::thread> timeout_thread_;
+  std::atomic<bool> timeout_killed_;
+  std::unique_ptr<std::thread> timeout_thread_{nullptr};
   std::mutex timeout_mutex_;
   std::condition_variable timeout_notify_;
 

repertory/librepertory/include/utils/unix/unix_utils.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal

repertory/librepertory/include/utils/utils.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal

repertory/librepertory/include/utils/windows/windows_utils.hpp

@@ -1,5 +1,5 @@
 /*
-  Copyright <2018-2024> <scott.e.graves@protonmail.com>
+  Copyright <2018-2025> <scott.e.graves@protonmail.com>
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal