From fd18ad910207fb46d2e5ab74b7f7642140b128df Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Sun, 22 Dec 2024 08:16:36 -0600
Subject: [PATCH] refactor

---
 .../src/file_manager/open_file_base.cpp        | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/repertory/librepertory/src/file_manager/open_file_base.cpp b/repertory/librepertory/src/file_manager/open_file_base.cpp
index 9bc7ce3d..d9596549 100644
--- a/repertory/librepertory/src/file_manager/open_file_base.cpp
+++ b/repertory/librepertory/src/file_manager/open_file_base.cpp
@@ -35,14 +35,16 @@ void open_file_base::download::notify(const api_error &err) {
 }
 
 auto open_file_base::download::wait() -> api_error {
-  if (not complete_) {
-    unique_mutex_lock lock(mtx_);
-    if (not complete_) {
-      notify_.wait(lock);
-    }
-    notify_.notify_all();
+  if (complete_) {
+    return error_;
   }
 
+  unique_mutex_lock lock(mtx_);
+  if (not complete_) {
+    notify_.wait(lock);
+  }
+  notify_.notify_all();
+
   return error_;
 }
 
@@ -195,7 +197,7 @@ auto open_file_base::get_filesystem_item() const -> filesystem_item {
 auto open_file_base::get_handles() const -> std::vector<std::uint64_t> {
   recur_mutex_lock file_lock(file_mtx_);
   std::vector<std::uint64_t> ret;
-  for (auto &&item : open_data_) {
+  for (const auto &item : open_data_) {
     ret.emplace_back(item.first);
   }
 
@@ -261,7 +263,7 @@ void open_file_base::remove_all() {
   auto open_data = open_data_;
   open_data_.clear();
 
-  for (auto &&data : open_data) {
+  for (const auto &data : open_data) {
     event_system::instance().raise<filesystem_item_handle_closed>(
         fsi_.api_path, data.first, fsi_.source_path, fsi_.directory, modified_);
   }