From ff136339620dcdb6ae9b3abfc0880d2eeba3b55a Mon Sep 17 00:00:00 2001
From: "Scott E. Graves" <scott.e.graves@protonmail.com>
Date: Wed, 13 Dec 2023 14:57:08 -0600
Subject: [PATCH] refactor

---
 src/providers/encrypt/encrypt_provider.cpp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/providers/encrypt/encrypt_provider.cpp b/src/providers/encrypt/encrypt_provider.cpp
index 8c28abe7..45418256 100644
--- a/src/providers/encrypt/encrypt_provider.cpp
+++ b/src/providers/encrypt/encrypt_provider.cpp
@@ -238,13 +238,14 @@ auto encrypt_provider::get_directory_item_count(
          std::filesystem::directory_iterator(source_path)) {
       count++;
     }
+
+    return count;
   } catch (const std::exception &ex) {
     utils::error::raise_error(__FUNCTION__, ex, cfg.path,
                               "failed to get directory item count");
-    return 0U;
   }
 
-  return count;
+  return 0U;
 }
 
 auto encrypt_provider::get_directory_items(const std::string &api_path,
@@ -282,8 +283,8 @@ auto encrypt_provider::get_directory_items(const std::string &api_path,
   }
 
   try {
-    auto dir_iter = std::filesystem::directory_iterator(source_path);
-    for (const auto &dir_entry : dir_iter) {
+    for (const auto &dir_entry :
+         std::filesystem::directory_iterator(source_path)) {
       try {
         std::string current_api_path{};
         if (dir_entry.is_directory()) {