Compare commits

..

No commits in common. "cd9ad1e32221aa2e455c28fd4f873bf56ce0b319" and "2ff72eebcefbe00e610c5a29c2f46362a4a52523" have entirely different histories.

5 changed files with 88 additions and 44 deletions

View File

@ -1,6 +1,5 @@
import 'package:collection/collection.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:repertory/constants.dart' as constants;
typedef Validator = bool Function(String);
@ -96,16 +95,6 @@ Map<String, dynamic> createDefaultSettings(String mountType) {
return {};
}
void displayErrorMessage(context, text) {
if (!context.mounted) {
return;
}
ScaffoldMessenger.of(
context,
).showSnackBar(SnackBar(content: Text(text, textAlign: TextAlign.center)));
}
String formatMountName(String type, String name) {
if (type == 'remote') {
return name.replaceAll('_', ':');

View File

@ -115,11 +115,6 @@ class MountList with ChangeNotifier {
await constants.navigatorKey.currentState?.pushReplacementNamed('/');
}
displayErrorMessage(
constants.navigatorKey.currentContext!,
'Mount removed externally. Reloading...',
);
_mountList = [];
notifyListeners();

View File

@ -137,19 +137,28 @@ class _AddMountScreenState extends State<AddMountScreen> {
List<String> failed = [];
if (!validateSettings(_settings[_mountType]!, failed)) {
for (var key in failed) {
displayErrorMessage(
context,
"Setting '$key' is not valid",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Setting '$key' is not valid",
textAlign: TextAlign.center,
),
),
);
}
return;
}
if (mountList.hasConfigName(_mountNameController.text)) {
return displayErrorMessage(
context,
"Configuration name '${_mountNameController.text}' already exists",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Configuration name '${_mountNameController.text}' already exists",
textAlign: TextAlign.center,
),
),
);
return;
}
if (_mountType == "Sia" || _mountType == "S3") {
@ -157,10 +166,15 @@ class _AddMountScreenState extends State<AddMountScreen> {
_settings[_mountType]!["${_mountType}Config"]["Bucket"]
as String;
if (mountList.hasBucketName(_mountType, bucket)) {
return displayErrorMessage(
context,
"Bucket '$bucket' already exists",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Bucket '$bucket' already exists",
textAlign: TextAlign.center,
),
),
);
return;
}
}

View File

@ -3,8 +3,7 @@ import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:provider/provider.dart';
import 'package:repertory/constants.dart' as constants;
import 'package:repertory/helpers.dart'
show Validator, displayErrorMessage, getSettingValidators;
import 'package:repertory/helpers.dart' show Validator, getSettingValidators;
import 'package:repertory/models/mount.dart';
import 'package:repertory/models/mount_list.dart';
import 'package:settings_ui/settings_ui.dart';
@ -84,10 +83,15 @@ class _MountSettingsWidgetState extends State<MountSettingsWidget> {
(validator) => !validator(updatedValue),
);
if (result != null) {
return displayErrorMessage(
context,
"Setting '$key' is not valid",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Setting '$key' is not valid",
textAlign: TextAlign.center,
),
),
);
return;
}
setState(() {
root[key] = int.parse(updatedValue);
@ -214,20 +218,30 @@ class _MountSettingsWidgetState extends State<MountSettingsWidget> {
child: const Text('OK'),
onPressed: () {
if (updatedValue1 != updatedValue2) {
return displayErrorMessage(
context,
"Setting '$key' does not match",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Setting '$key' does not match",
textAlign: TextAlign.center,
),
),
);
return;
}
final result = validators.firstWhereOrNull(
(validator) => !validator(updatedValue1),
);
if (result != null) {
return displayErrorMessage(
context,
"Setting '$key' is not valid",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Setting '$key' is not valid",
textAlign: TextAlign.center,
),
),
);
return;
}
setState(() {
@ -303,10 +317,15 @@ class _MountSettingsWidgetState extends State<MountSettingsWidget> {
(validator) => !validator(updatedValue),
);
if (result != null) {
return displayErrorMessage(
context,
"Setting '$key' is not valid",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(
"Setting '$key' is not valid",
textAlign: TextAlign.center,
),
),
);
return;
}
setState(() {
root[key] = updatedValue;

View File

@ -92,7 +92,19 @@ class _MountWidgetState extends State<MountWidget> {
}
if (!isMounted && location == null) {
displayErrorMessage(context, "Mount location is not set");
if (!context.mounted) {
return cleanup();
}
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: const Text(
"Mount location is not set",
textAlign: TextAlign.center,
),
),
);
return cleanup();
}
@ -105,7 +117,17 @@ class _MountWidgetState extends State<MountWidget> {
return cleanup();
}
displayErrorMessage(context, "Mount location not found");
ScaffoldMessenger.of(
constants.navigatorKey.currentContext!,
).showSnackBar(
SnackBar(
content: const Text(
"Mount location not found",
textAlign: TextAlign.center,
),
),
);
return cleanup();
}
: null;
@ -153,10 +175,15 @@ class _MountWidgetState extends State<MountWidget> {
(validator) => !validator(currentLocation ?? ''),
);
if (result != null) {
return displayErrorMessage(
context,
"Mount location is not valid",
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: const Text(
"Mount location is not valid",
textAlign: TextAlign.center,
),
),
);
return;
}
Navigator.of(context).pop(currentLocation);
},