Public/Ext4Fsd
1
0
Fork 0
mirror of https://github.com/bobranten/Ext4Fsd.git synced 2025-10-30 05:18:31 -05:00
Code Activity

added two comments

Browse Source
This commit is contained in:
Bo Branten
2024-08-27 13:49:53 +02:00
parent 4445212245
commit c5e39e6401
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Ext4Fsd/close.c
View File

@@ -186,6 +186,9 @@ Ext2Close (IN PEXT2_IRP_CONTEXT IrpContext)
return Status; return Status;
} }
/* TO INVESTIGATE: Since no call in Ext2Close return STATUS_PENDING (because the wait parameter to
ExAcquireResourceExclusiveLite is TRUE) the functions below will never be called and could be removed? */
VOID VOID
Ext2QueueCloseRequest (IN PEXT2_IRP_CONTEXT IrpContext) Ext2QueueCloseRequest (IN PEXT2_IRP_CONTEXT IrpContext)
{ {

6
Ext4Fsd/flush.c
View File

@@ -17,7 +17,6 @@ extern PEXT2_GLOBAL Ext2Global;
/* DEFINITIONS *************************************************************/ /* DEFINITIONS *************************************************************/
NTSTATUS NTSTATUS
Ext2FlushCompletionRoutine ( Ext2FlushCompletionRoutine (
IN PDEVICE_OBJECT DeviceObject, IN PDEVICE_OBJECT DeviceObject,
@@ -28,7 +27,6 @@ Ext2FlushCompletionRoutine (
if (Irp->PendingReturned) if (Irp->PendingReturned)
IoMarkIrpPending( Irp ); IoMarkIrpPending( Irp );
if (Irp->IoStatus.Status == STATUS_INVALID_DEVICE_REQUEST) if (Irp->IoStatus.Status == STATUS_INVALID_DEVICE_REQUEST)
Irp->IoStatus.Status = STATUS_SUCCESS; Irp->IoStatus.Status = STATUS_SUCCESS;
@@ -139,7 +137,6 @@ Ext2FlushFiles(
return IoStatus.Status; return IoStatus.Status;
} }
NTSTATUS NTSTATUS
Ext2Flush (IN PEXT2_IRP_CONTEXT IrpContext) Ext2Flush (IN PEXT2_IRP_CONTEXT IrpContext)
{ {
@@ -213,6 +210,8 @@ Ext2Flush (IN PEXT2_IRP_CONTEXT IrpContext)
__leave; __leave;
} }
/* TO INVESTIGATE: Ext2FlushFiles will always return STATUS_SUCCESS so Ext2FlushVolume will never be called? */
Status = Ext2FlushVolume(IrpContext, (PEXT2_VCB)(FcbOrVcb), FALSE); Status = Ext2FlushVolume(IrpContext, (PEXT2_VCB)(FcbOrVcb), FALSE);
if (NT_SUCCESS(Status) && IsFlagOn(Vcb->Volume->Flags, FO_FILE_MODIFIED)) { if (NT_SUCCESS(Status) && IsFlagOn(Vcb->Volume->Flags, FO_FILE_MODIFIED)) {
@@ -235,7 +234,6 @@ Ext2Flush (IN PEXT2_IRP_CONTEXT IrpContext)
DEBUG(DL_INF, ("Ext2Flush-post: total mcb records=%u\n", DEBUG(DL_INF, ("Ext2Flush-post: total mcb records=%u\n",
FsRtlNumberOfRunsInLargeMcb(&Vcb->Extents))); FsRtlNumberOfRunsInLargeMcb(&Vcb->Extents)));
} __finally { } __finally {
if (MainResourceAcquired) { if (MainResourceAcquired) {