1
0
mirror of https://github.com/veracrypt/VeraCrypt.git synced 2025-11-12 19:38:26 -06:00
Commit Graph

306 Commits

Author SHA1 Message Date
Mounir IDRASSI
8eb232a4a3 MacOS: set minimum target to OSX 12. Fix About menu not working.
The modification to Forms.cpp is temporary until we find a better
approach
2023-10-01 18:51:20 +02:00
Mounir IDRASSI
14fee0da1a Linux/macOS: preserve unknown entries in configuration file
This helps to preserve unknown entries that may be used by future
versions of VeraCrypt (forward compatibility) or entries used by old
versions that were removed from current version (backward compatibility)
2023-09-02 01:37:52 +02:00
Unit 193
d49c75370a Allow cross compilation. (#1182) 2023-08-21 11:24:25 +02:00
Mounir IDRASSI
9d8afdad93 Linux: Fix wrong max size for hidden volume in CLI direct mode creation
There was a logical bug that made the code check the filesystem size of
the device path "/dev" instead of using the actual size of the device

Fix #1180
2023-08-19 20:44:32 +02:00
Jertzukka
eb2f5f33c9 Linux: Flush stdout explicitly when reading stdin (#1172)
Rules of automatic flushing of stdout buffer is implementation-defined
behaviour. In glibc this is automatically flushed, but we can't rely
on it for other implementations such as musl.
2023-08-12 09:18:57 +02:00
Jertzukka
5c9e135c9e Linux: Typo fix and consistency in help command (#1169) 2023-08-12 09:17:18 +02:00
Deniz Türkoglu
8f3082c3ef Call EnsureVisible() for OSX in OnActivate (#1167)
When using multiple monitors, the resolution can change in OSX,
during plug-in/off off the display(s). To avoid window becoming
non-usable, there is EnsureVisible, that is called in several
places.

However, if you minimize VeraCrypt on the bigger screen, and
restore it in the main screen of a MacBook, after unplugging, the
window will become unusable (unless you know that clicking 'About'
calls EnsureVisible :-)).

Call EnsureVisible OnActivate so MainFrame is always functional
across screens, even when minimized.
2023-08-07 22:53:19 +02:00
kovalev0
5a6b445f0e fix warnings and UB (#1164)
* Crypto: fix warning mismatched bound

../Crypto/cpu.c:67:32: warning: argument 2 of type 'uint32[4]'
{aka 'unsigned int[4]'} with mismatched bound [-Warray-parameter=]
   67 | int CpuId(uint32 input, uint32 output[4])
      |                         ~~~~~~~^~~~~~~~~
In file included from ../Crypto/cpu.c:3:
../Crypto/cpu.h:236:33: note: previously declared as 'uint32 *'
{aka 'unsigned int *'}
  236 | int CpuId(uint32 input, uint32 *output);

Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>

* Core/Unix: fix warning ignoring return value

Unix/CoreUnix.cpp: In member function 'virtual std::shared_ptr<VeraCrypt:\
:VolumeInfo> VeraCrypt::CoreUnix::MountVolume(VeraCrypt::MountOptions&)':
Unix/CoreUnix.cpp:682:55: warning: ignoring return value of
'int chown(const char*, __uid_t, __gid_t)' declared with attribute
'warn_unused_result' [-Wunused-result]
  682 |     chown (mountPoint.c_str(), GetRealUserId(), GetRealGroupId());
      |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>

* Main/Forms: fix warning cast to pointer from integer of different size

Forms/MainFrame.cpp: In member function 'void VeraCrypt::MainFrame:\
:UpdateVolumeList()':

Forms/MainFrame.cpp:1718:106: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
 1718 |       Gui->InsertToListCtrl (SlotListCtrl, ++prevItemIndex,
        fields, 0, (void *) volume->SlotNumber);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Forms/MainFrame.cpp:1753:114: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
 1753 |       Gui->InsertToListCtrl (SlotListCtrl, ++prevItemIndex,
        fields, 0, (void *) slotNumber);
      |            ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>

* Crypto: fix undefined behavior signed integer overflow

In function 'twofish_set_key':
cc1: warning: iteration 4 invokes undefined behavior
[-Waggressive-loop-optimizations]
../Crypto/Twofish.c:626:23: note: within this loop
  626 |         for (i = 0; i != 40; i += 2)
      |                     ~~^~~~~

Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>

---------

Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Co-authored-by: Vasiliy Kovalev <kovalev@altlinux.org>
2023-08-04 23:49:11 +02:00
Mounir IDRASSI
3f976c24d2 Linux/macOS: Remove TrueCrypt support 2023-07-24 08:48:52 +02:00
Mounir IDRASSI
ba74b9d5b8 Linux/macOS:Add EMV option checkbox to the fbp file. Remove TrueCrypt checkboxes.
We also update to wxFormBuilder 3.10.1
2023-07-23 21:45:16 +02:00
Springfield Data Recovery
f037dae413 Update UserInterface.cpp (#1155)
Docs specify cascading encryption should be specified as "AES(Twofish)" but on Linux it requires "AES-Twofish".
2023-07-23 09:13:03 +02:00
Jertzukka
232d3290b0 Linux: Overwriting file container allows you to use its space (#1147)
When replacing a file container, we increase the `diskSpace`
by the file container's size. This doesn't affect the hidden volume
space logic, as in that case we use `MaxVolumeSize` when
`MaxVolumeSizeValid` is true instead of `AvailableDiskSpace`.
2023-07-05 19:00:37 +09:00
Mounir IDRASSI
df62c0227c Linux: Fix wrong size for hidden volume when selecting the option to use all free space (fix by @Jertzukka) 2023-06-29 23:24:47 +02:00
Mounir IDRASSI
417ff5564e Linux/FreeBSD: Make pcsclite a dependency of the packages and the generic installer 2023-06-29 23:15:03 +02:00
Mounir IDRASSI
034b64f415 EMV keyfile support: Overall code improvements and bug fixes 2023-06-29 00:06:20 +02:00
mmauv
502ab9112a Add EMV functionality (#1080)
* Add basic strcture needed for EMV implementation

* Add demo EMV functionality with C code pasted in a very dirty and unsafe way. NOT FINAL

* Refactor IccExtractor Structure

* Fix Makefile

* fix include file

* move global variables from h to c

* revert to memcpy

* fix icc data recovery functions

* Add EMV functionalities on windows

* Make EMVToken structures like SecurityToken

* Define constants instead of hard coded values

* Token structures created with inheritance

* refactor TokenKeyfile to use inherit. + polymor.

* add Token.h + Token.cpp in modules in VS2010

* Add a comment at each use of SecurityToken class or objects

* SecurityTokenKeyfilesDialog preparation

* Implemennt GetAvailableTokens in Token class on windows

* merge

* up (patching for Windows)

* foreach Token.cpp corrected

* Display EMV keyfiles on first window in graphic interface

* Add token to Windows UI

* EMVToken selection on OKButton on Linux

* Keyfile.cpp optimization

* Move getKeyfileData in the token class

* EMV::Token GetAvailableKeyfiles() base

* Move getKeyfileData in the token class on unix

* Remove test comments

* Warnings resolved

* RemoveeSecurityTokenLibraryNotInitialized exception if at least one emv token is detected

* Adding new files

* Remove old files and add the new version to the windows project

* Change make_shared to shared_ptr constructor

* IccExtractor integration working on linux

* Throwing card not EMV execption

* catch error when not EMV type in EMVToken::GetAvailableKeyfiles

* Change types to compile on windows

* list all keyfiles, security keyfiles and emv keyfiles in command line

* Change type to be coherent and remove old todo comments

* Remove todo comments

* Change indentation and resolve a bug from previous commit

* Use polymorphism for GetKeyfileData and add export option for EMVTokens on Linux

* Linux : Allow to export EMV Tokens in command lines, Windows : Disable the delete button when EMV Keyfiles are selected

* Remove SlotId from TokenInfo as it is already in Token

* Correct errors on Linux

* Disable delete option if one EMV Token is selected on Linux

* Fix bug enabling delete button if nothing is selected

* emv data used as reference then burnt

* use of normal files in linux corrected

* help updated

* help updated for export functionnality

* option EMV added to graphic interface but not yet working

* Bug fix : Allow to use multiple EMV on windows

* EMV Option added to UserPreferences

* EMV Option working for Linux

* EMV option added to Windows (not working yet)

* [NOT TESTED] EMV option for Windows

* Working EMV option on Windows

* EMV Option for data extraction working for volume creation

* EMV Option for data extraction working for Mount

* EMV Option for data extraction working for mounting favorites volumes

* EMV Option for extraction working for Changing volume password, Set Derivation Key Algorithm and Add or remove keyfile from volume

* Windows : re-checking EMV Option when getting data

* Removing error catches in the IccDataExtractor classe (It only throws error now). Changing GetPan signature to resemble the other functions signatures more

* Changing EMV errors

- Only throwing ICCExtractionException from outside of the ICC module.
- Catching all TLVExceptions and PCSCExceptions to throw the right ICCExtractionException

- Deleting APDU exceptions.

* First version of the documentation

* Adding function pointers for winscard library (but it crashes VeraCrypt)

* Debugging function pointers

* The import of the library on windows work as expected now

* Reverting EMVToken.cpp changes used to test to library import

* Searching for the System32 path instead of hard codding it

* Fixing the bug were VeraCrypt crashes if there is no readers when  "add Token files" is clicked

* Winscard library not initialized in object constructor anymore to delay it after EMVOption check

* Remove winscard lib from windows dependencies

* Properly displaying errors

* Adding a dot in Language.xml

* Catching TLVException

* Removing unused code

* Remove unusefull comments

* Trying to fix 0x1f error

* Update IccDataExtractor.cpp

* Delete History.xml

* Fix get data without get pan

* Cleanup code

* changes for linux compilation but linking not working

* error handling for linux

* erasing emv data

* Burn PAN

* Burn PAN from memory

* Uncomment selfcheck before merging master

* burn corrected

* EMV errors handling for Linux

* EMV working for Linux CLI

* Doc : Winscard Linux package and VeraCrypt versions

---------

Co-authored-by: doriandu45 <d45.poubelle@gmail.com>
Co-authored-by: red4game <redemgaiming@gmail.com>
Co-authored-by: Brice.Namy <brice.namy@insa-rennes.fr>
Co-authored-by: vocthor <pieceo108@gmail.com>
Co-authored-by: vocthor <67202139+vocthor@users.noreply.github.com>
Co-authored-by: Andrei COCAN <andrei.cocan@insa-rennes.fr>
Co-authored-by: AndreiCocan <95496161+AndreiCocan@users.noreply.github.com>
Co-authored-by: francoisLEROUX <francois3443@gmail.com>
2023-06-28 22:51:43 +02:00
Mounir IDRASSI
36a055f669 Linux/macOS: only wipe password/PIM text controls if they are not empty
This fixes a crash on macOS with latest wxWidgets 3.2.2.1 where
GetLineLength returns -1
2023-06-14 00:31:46 +02:00
Mounir IDRASSI
440df02355 Linux: Fix compatibility of generic installers with old Linux distros
In old Linux distributions, tar command doesn't support
"--keep-directory-symlink" so we now dynamically detect if this switch
is support and then we use it if it is available
2023-06-13 23:34:04 +02:00
Mounir IDRASSI
b25ebeb7b4 Linux/macOS: Fix error during creation of installation package
"-R" switch was missing from the "cp" command
2023-06-05 22:46:20 +02:00
Jertzukka
6ced991d98 Fix issues launching fsck via terminal on Linux (#1086)
Currently on a system without xterm or konsole (like fresh
Ubuntu install) the fsck check will not launch. Added
gnome-terminal as an alternative and fixed an issue where
konsole will always error out as --title and --caption are
no longer valid arguments.

Previously the error message was simply "xterm not found", so
new LangString LINUX_EX2MSG_TERMINALNOTFOUND was added to let the
user knows which programs they need to get the feature working.
2023-06-01 09:01:53 +02:00
Jertzukka
4e5529bee0 Prevent failing fs options being shown in --text --create (#1078)
Removes the options exFAT and Btrfs being shown when creating a
volume in text mode when the system does not support them and will
end up erroring out at the end. Hide Btrfs option when the volume
is too small, as we will anyways fail right after.

Hardcoded numbering changed to dynamic as the available options
are not necessarily consecutive.
2023-05-27 18:08:51 +02:00
Mounir IDRASSI
b872702309 Linux: Fix printing error when checking freespace during volume creation
No parent directory specified in the path, we assume current directory
We first check if parent directory exists before checking its free space
using wxgetDiskSpace

Based on idea proposed by @bogdro in PR#1025
2023-05-22 01:05:17 +02:00
Mounir IDRASSI
eb61010ce2 Linux/macOS: Better handling of wrong PIM value in text mode (enhances PR#1026) 2023-05-21 17:27:33 +02:00
Bogdan Drozdowski
b05b18928f Keep PIM secret and re-ask when user entered a wrong value (#1026)
Co-authored-by: Bogdan Drozdowski <>
2023-05-21 17:21:21 +02:00
Es
e59581918f wxWidget assert failure bug (#999)
* Removal of any of the any of `wxALIGN_RIGHT`/`wxALIGN_CENTRE_HORIZONTAL`/`wxALIGN_BOTTOM`/`wxALIGN_CENTRE_VERTICAL` when used in conjunction with `wxEXPAND`

wxWidget has an "assert" that gets triggered anytime `wxEXPAND` gets used with an alignment property (useless override). This leads to a popup backtrace everytime a non-compliant widget is opened.

* Removal of missed `wxALIGN_RIGHT`/`wxALIGN_CENTRE_HORIZONTAL`/`wxALIGN_BOTTOM`/`wxALIGN_CENTRE_VERTICAL` when used in conjunction with `wxEXPAND`

* Removed property 'label' for wxMenuBar as no longer used (wxFormBuilder)

* Removed redundant 'wxALIGN_RIGHT' for the "OK" button in the preference panel (there is a spacer already in-place that pushes the buttons to the right)

* Removed redundant 'wxALIGN_RIGHT' for items in the wizard panel's (`WizardFrameBase`) button bar and added width spacing for the 2 spacers between the buttons to make up for the change.

* Changed constructor signature for the `WizardPage` and all subclasses

 The addition of the wxString 'name' arg brings it inline with the new wxFromBuilder v3.10.1 output so that editing+generating the forms from it won't brake the build now.

* Removed remaining redundant 'wxALIGN_*' that were paired with 'wxEXPAND'.

* Added missing default flags to wxFileName::Normalize(..) method

The old empty initialization which was fine up to v2.8.12 of wxWidget gives off a compile warning. Since the default `wxPATH_NORM_ALL` is now depreciated (v3.x) the equivalent individual flags must be explicitly given.

* Changed spaces to tabs to bring last commit inline with the rest of the src code
2023-05-19 00:44:13 +02:00
Jertzukka
8072207eb6 Add a new LangString 'LINUX_VOL_MOUNTED' to show when volume mounted. Fixes (#1029)
the issue of 'LINUX_VOL_DISMOUNTED' being shown even when not dismounting.
2023-05-18 22:59:36 +02:00
Mounir IDRASSI
8e443c25cc Linux/macOS: Suppress asserts displayed by wxWidgets 3.1.6+ for sizer flags until we fix all sizer flags in our UI. 2023-05-18 21:25:07 +02:00
Kenneth Chew
a23d4392fb Fix incorrect text color in dark mode (#920) 2022-08-21 17:58:08 +02:00
Mounir IDRASSI
c145b337cb Linux/MacOSX: Fix hidden volume settings not correctly displayed when enabling hidden volume protection in mount options window 2022-02-19 22:35:34 +01:00
Mounir IDRASSI
b1ae5f4740 Update copyrights following integration of LZMA SDK 2022-02-11 00:37:25 +01:00
Mounir IDRASSI
abfef8821d MacOSX: remove write permission also from group on application bundle 2022-01-08 11:08:47 +01:00
Mounir IDRASSI
ce733d547e Update copyright year to 2022 2022-01-02 21:52:23 +01:00
Mounir IDRASSI
68131ac91b MacOSX: correct permission of VeraCrypt application bundle during packaging 2021-12-24 23:57:27 +01:00
Mounir IDRASSI
43cf5d7b53 Linux/macOS/FreeBSD: return error if unknown filesystem value specified in --filesystem switch 2021-11-21 21:45:09 +01:00
Mounir IDRASSI
491fed3494 Linux/FreeBSD: Fix calling "make install" without specifying DESTDIR, which should work by installing into /usr 2021-11-21 21:45:01 +01:00
Mounir IDRASSI
5e547b127f Linux/macOS: Add CLI switch (--size=max) and UI option to give a file container all available free space.
This commit also makes --size switch accept KiB/MiB/GiB/TiB prefixes and adds TiB choice in UI.
2021-09-21 01:41:25 +02:00
a1346054
32052f214b Minor cleanup of the repo (#822)
* *: source files should not be executable

* *: make sure files have final newline

* *: remove BOM from text files

* translations: unify headers

* *: fix typos

* *: trim excess whitespace
2021-09-04 21:59:25 +02:00
Mounir IDRASSI
2216f739c4 Update copyright year to 2021 2021-08-30 00:26:11 +02:00
Mounir IDRASSI
7df5a58adc Linux: Better Linux desktop integration. Add mount.veracrypt script for fstab (proposed by unit193 at https://github.com/veracrypt/VeraCrypt/issues/814) 2021-08-21 22:36:48 +02:00
Mounir IDRASSI
49a1252306 Fix typo in GraphicUserInterface.cpp 2021-08-21 22:36:40 +02:00
Mounir IDRASSI
0809f456d9 Linux/macOS: print LANG environment variable to console only in DEBUG mode 2021-08-21 19:18:28 +02:00
Unit 193
849cd010e8 Add compile-time toggleable support for application indicators, off by default. (#815)
This tries to figure out, via wx-config, if you're using GTK2 or GTK3
and uses the associated Ayatana library.
2021-08-16 00:54:21 +02:00
Mounir IDRASSI
8ae5a715d6 MacOSX: First native Apple M1 support 2021-08-15 01:07:17 +02:00
kokokodak
c8830a04b4 Add support for OpenBSD (#779)
* OpenBSD: add basic support

	modified:   Build/Include/Makefile.inc
	modified:   Driver/Fuse/FuseService.cpp
	modified:   Main/FatalErrorHandler.cpp
	modified:   Makefile
	modified:   Platform/Unix/File.cpp
	modified:   Platform/Unix/FilesystemPath.cpp
	modified:   Platform/Unix/SystemInfo.cpp

* OpenBSD: some necessary files were missing

	new file:   Core/Unix/OpenBSD/CoreOpenBSD.cpp
	new file:   Core/Unix/OpenBSD/CoreOpenBSD.h
	new file:   Core/Unix/OpenBSD/System.h
2021-07-14 13:43:34 +02:00
T-Bonhagen
874d29390f fix Program freeze Volume Creation Wizard linux (#726) 2021-02-21 10:16:24 +01:00
Mounir IDRASSI
d10739a45e Linux/MacOSX: make LanguageStrings.cpp build depend on Language.xml.h since it uses it 2020-12-20 01:22:25 +01:00
Mounir IDRASSI
4b9bfecf6a Linux: fix build error with old gcc compilers that don't have std::getenv 2020-12-20 01:22:16 +01:00
T-Bonhagen
38ad7650ac new xml Tag for en and de (#708)
* new xml Tag for en and de

* add linux support for env LANG

* precopiled header into TrueCrypt.fdp to substitute '_()' with 'LangString[]'

* more LangString in Code

* add Language xml's to Linux Setup location

* backup language for linux is en

* remove Language.en.xml install

* rearange new xml lines to end

* yes/no dialogs now translated

* All OK/Cancel Button now support international

Co-authored-by: tb@tbon.de <tb@tbon.de>
2020-12-11 18:42:59 +01:00
Mounir IDRASSI
0015420c43 MacOSX: always use "pkg-config fuse" for linking since recent versions of osxfuse 3.x support this 2020-11-29 00:51:51 +01:00
Mounir IDRASSI
5f08b45dcd MacOSX: revert part of changes of commit "Fixed macFUSE support for macOS 11 (Big Sur)"
We only changes related to the fix
2020-11-29 00:51:37 +01:00