Public/libcron
1
0
Fork 0
mirror of https://github.com/PerMalmberg/libcron.git synced 2025-04-22 08:23:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

Initial thought about handling clock changes: Follow RedHat's implementation at https://access.redhat.com/solutions/477963

Browse Source 
If time moves >=3h, then consider it a adjustment and reschedule based on the new time.
If time changes backwards <3h, prevent running tasks twice.
If forward <3h run tasks that would have run in the skipped time.
This commit is contained in:
Per Malmberg 2018-03-12 00:08:20 +01:00
parent 9f7c5dc2fa
commit 47a615897a
1 changed files with 25 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/CronTest.cpp
View File

@ -6,9 +6,9 @@
using namespace libcron; using namespace libcron;
using namespace std::chrono; using namespace std::chrono;
std::string create_schedule_expiring_in(std::shared_ptr<ICronClock> clock, hours h, minutes m, seconds s) std::string create_schedule_expiring_in(std::chrono::system_clock::time_point now, hours h, minutes m, seconds s)
{ {
auto now = clock->now() + h + m + s; now = now + h + m + s;
auto dt = CronSchedule::to_calendar_time(now); auto dt = CronSchedule::to_calendar_time(now);
std::string res{}; std::string res{};
@ -66,7 +66,7 @@ SCENARIO("Adding a task that expires in the future")
auto expired = false; auto expired = false;
Cron c; Cron c;
REQUIRE(c.add_schedule("A task", create_schedule_expiring_in(c.get_clock(), hours{0}, minutes{0}, seconds{3}), REQUIRE(c.add_schedule("A task", create_schedule_expiring_in(c.get_clock()->now(), hours{0}, minutes{0}, seconds{3}),
[&expired]() [&expired]()
{ {
expired = true; expired = true;
@ -107,14 +107,14 @@ SCENARIO("Task priority")
Cron c; Cron c;
REQUIRE(c.add_schedule("Five", create_schedule_expiring_in(c.get_clock(), hours{0}, minutes{0}, seconds{5}), REQUIRE(c.add_schedule("Five", create_schedule_expiring_in(c.get_clock()->now(), hours{0}, minutes{0}, seconds{5}),
[&_5_second_expired]() [&_5_second_expired]()
{ {
_5_second_expired++; _5_second_expired++;
}) })
); );
REQUIRE(c.add_schedule("Three", create_schedule_expiring_in(c.get_clock(), hours{0}, minutes{0}, seconds{3}), REQUIRE(c.add_schedule("Three", create_schedule_expiring_in(c.get_clock()->now(), hours{0}, minutes{0}, seconds{3}),
[&_3_second_expired]() [&_3_second_expired]()
{ {
_3_second_expired++; _3_second_expired++;
@ -185,6 +185,24 @@ SCENARIO("Task priority")
REQUIRE(_5_second_expired == 1); REQUIRE(_5_second_expired == 1);
} }
} }
} }
} }
//SCENARIO("Clock changes")
//{
// GIVEN("A Cron instance with a single task expiring in 4h")
// {
// Cron c;
// auto clock = c.get_clock();
// system_clock::time_point time_from_task;
// auto now = clock->now();
// REQUIRE(c.add_schedule("Task", create_schedule_expiring_in(now, hours{4}, minutes{0}, seconds{0}),
// [clock, &time_from_task]()
// {
// time_from_task = clock->now();
// })
// );
//
//
// }
//}