Public/winfsp
1
0
Fork 0
mirror of https://github.com/winfsp/winfsp.git synced 2025-04-22 16:33:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

dll: fsop: implement FSCTL_DELETE_REPARSE_POINT parameter checking

Browse Source
This commit is contained in:
Bill Zissimopoulos 2016-08-22 00:40:01 -07:00
parent 981e60643f
commit 34e653a275
1 changed files with 74 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

99
src/dll/fsop.c
View File

@ -885,7 +885,7 @@ FSP_API NTSTATUS FspFileSystemOpFileSystemControl(FSP_FILE_SYSTEM *FileSystem,
FSP_FSCTL_TRANSACT_REQ *Request, FSP_FSCTL_TRANSACT_RSP *Response) FSP_FSCTL_TRANSACT_REQ *Request, FSP_FSCTL_TRANSACT_RSP *Response)
{ {
NTSTATUS Result; NTSTATUS Result;
PREPARSE_DATA_BUFFER ReparseData; PREPARSE_DATA_BUFFER GetReparseData, SetReparseData;
SIZE_T Offset, Size; SIZE_T Offset, Size;
Result = STATUS_INVALID_DEVICE_REQUEST; Result = STATUS_INVALID_DEVICE_REQUEST;
@ -894,8 +894,8 @@ FSP_API NTSTATUS FspFileSystemOpFileSystemControl(FSP_FILE_SYSTEM *FileSystem,
case FSCTL_GET_REPARSE_POINT: case FSCTL_GET_REPARSE_POINT:
if (0 != FileSystem->Interface->GetReparsePoint) if (0 != FileSystem->Interface->GetReparsePoint)
{ {
ReparseData = (PREPARSE_DATA_BUFFER)Response->Buffer; GetReparseData = (PREPARSE_DATA_BUFFER)Response->Buffer;
memset(ReparseData, 0, sizeof *ReparseData); memset(GetReparseData, 0, sizeof *GetReparseData);
if (FileSystem->ReparsePointsSymlinkOnly) if (FileSystem->ReparsePointsSymlinkOnly)
{ {
@ -904,28 +904,28 @@ FSP_API NTSTATUS FspFileSystemOpFileSystemControl(FSP_FILE_SYSTEM *FileSystem,
Result = FileSystem->Interface->GetReparsePoint(FileSystem, Request, Result = FileSystem->Interface->GetReparsePoint(FileSystem, Request,
(PVOID)Request->Req.FileSystemControl.UserContext, (PVOID)Request->Req.FileSystemControl.UserContext,
(PWSTR)Request->Buffer, (PWSTR)Request->Buffer,
ReparseData->SymbolicLinkReparseBuffer.PathBuffer, GetReparseData->SymbolicLinkReparseBuffer.PathBuffer,
&Size); &Size);
if (NT_SUCCESS(Result)) if (NT_SUCCESS(Result))
{ {
Offset = 0; Offset = 0;
if (Size > 4 * sizeof(WCHAR) && if (Size > 4 * sizeof(WCHAR) &&
'\\' == ReparseData->SymbolicLinkReparseBuffer.PathBuffer[0] && '\\' == GetReparseData->SymbolicLinkReparseBuffer.PathBuffer[0] &&
'?' == ReparseData->SymbolicLinkReparseBuffer.PathBuffer[1] && '?' == GetReparseData->SymbolicLinkReparseBuffer.PathBuffer[1] &&
'?' == ReparseData->SymbolicLinkReparseBuffer.PathBuffer[2] && '?' == GetReparseData->SymbolicLinkReparseBuffer.PathBuffer[2] &&
'\\' == ReparseData->SymbolicLinkReparseBuffer.PathBuffer[3]) '\\' == GetReparseData->SymbolicLinkReparseBuffer.PathBuffer[3])
Offset = 4 * sizeof(WCHAR); Offset = 4 * sizeof(WCHAR);
ReparseData->ReparseTag = IO_REPARSE_TAG_SYMLINK; GetReparseData->ReparseTag = IO_REPARSE_TAG_SYMLINK;
ReparseData->ReparseDataLength = (USHORT)( GetReparseData->ReparseDataLength = (USHORT)(
FIELD_OFFSET(REPARSE_DATA_BUFFER, SymbolicLinkReparseBuffer.PathBuffer) - FIELD_OFFSET(REPARSE_DATA_BUFFER, SymbolicLinkReparseBuffer.PathBuffer) -
FIELD_OFFSET(REPARSE_DATA_BUFFER, SymbolicLinkReparseBuffer) + FIELD_OFFSET(REPARSE_DATA_BUFFER, SymbolicLinkReparseBuffer) +
Size); Size);
ReparseData->SymbolicLinkReparseBuffer.SubstituteNameOffset = 0; GetReparseData->SymbolicLinkReparseBuffer.SubstituteNameOffset = 0;
ReparseData->SymbolicLinkReparseBuffer.SubstituteNameLength = (USHORT)Size; GetReparseData->SymbolicLinkReparseBuffer.SubstituteNameLength = (USHORT)Size;
ReparseData->SymbolicLinkReparseBuffer.PrintNameOffset = (USHORT)Offset; GetReparseData->SymbolicLinkReparseBuffer.PrintNameOffset = (USHORT)Offset;
ReparseData->SymbolicLinkReparseBuffer.PrintNameLength = (USHORT)(Size - Offset); GetReparseData->SymbolicLinkReparseBuffer.PrintNameLength = (USHORT)(Size - Offset);
ReparseData->SymbolicLinkReparseBuffer.Flags = 0 == Offset ? GetReparseData->SymbolicLinkReparseBuffer.Flags = 0 == Offset ?
0 : SYMLINK_FLAG_RELATIVE; 0 : SYMLINK_FLAG_RELATIVE;
Response->Rsp.FileSystemControl.Buffer.Size = (UINT16)( Response->Rsp.FileSystemControl.Buffer.Size = (UINT16)(
@ -938,7 +938,7 @@ FSP_API NTSTATUS FspFileSystemOpFileSystemControl(FSP_FILE_SYSTEM *FileSystem,
Size = FSP_FSCTL_TRANSACT_RSP_SIZEMAX - FIELD_OFFSET(FSP_FSCTL_TRANSACT_RSP, Buffer); Size = FSP_FSCTL_TRANSACT_RSP_SIZEMAX - FIELD_OFFSET(FSP_FSCTL_TRANSACT_RSP, Buffer);
Result = FileSystem->Interface->GetReparsePoint(FileSystem, Request, Result = FileSystem->Interface->GetReparsePoint(FileSystem, Request,
(PVOID)Request->Req.FileSystemControl.UserContext, (PVOID)Request->Req.FileSystemControl.UserContext,
(PWSTR)Request->Buffer, ReparseData, &Size); (PWSTR)Request->Buffer, GetReparseData, &Size);
if (NT_SUCCESS(Result)) if (NT_SUCCESS(Result))
Response->Rsp.FileSystemControl.Buffer.Size = (UINT16)Size; Response->Rsp.FileSystemControl.Buffer.Size = (UINT16)Size;
} }
@ -947,7 +947,7 @@ FSP_API NTSTATUS FspFileSystemOpFileSystemControl(FSP_FILE_SYSTEM *FileSystem,
case FSCTL_SET_REPARSE_POINT: case FSCTL_SET_REPARSE_POINT:
if (0 != FileSystem->Interface->SetReparsePoint) if (0 != FileSystem->Interface->SetReparsePoint)
{ {
ReparseData = (PREPARSE_DATA_BUFFER) SetReparseData = (PREPARSE_DATA_BUFFER)
(Request->Buffer + Request->Req.FileSystemControl.Buffer.Offset); (Request->Buffer + Request->Req.FileSystemControl.Buffer.Offset);
if (FileSystem->ReparsePointsSymlinkOnly) if (FileSystem->ReparsePointsSymlinkOnly)
@ -955,23 +955,72 @@ FSP_API NTSTATUS FspFileSystemOpFileSystemControl(FSP_FILE_SYSTEM *FileSystem,
Result = FileSystem->Interface->SetReparsePoint(FileSystem, Request, Result = FileSystem->Interface->SetReparsePoint(FileSystem, Request,
(PVOID)Request->Req.FileSystemControl.UserContext, (PVOID)Request->Req.FileSystemControl.UserContext,
(PWSTR)Request->Buffer, (PWSTR)Request->Buffer,
ReparseData->SymbolicLinkReparseBuffer.PathBuffer + SetReparseData->SymbolicLinkReparseBuffer.PathBuffer +
ReparseData->SymbolicLinkReparseBuffer.SubstituteNameOffset / sizeof(WCHAR), SetReparseData->SymbolicLinkReparseBuffer.SubstituteNameOffset / sizeof(WCHAR),
ReparseData->SymbolicLinkReparseBuffer.SubstituteNameLength); SetReparseData->SymbolicLinkReparseBuffer.SubstituteNameLength);
} }
else else
Result = FileSystem->Interface->SetReparsePoint(FileSystem, Request, Result = FileSystem->Interface->SetReparsePoint(FileSystem, Request,
(PVOID)Request->Req.FileSystemControl.UserContext, (PVOID)Request->Req.FileSystemControl.UserContext,
(PWSTR)Request->Buffer, (PWSTR)Request->Buffer,
ReparseData, SetReparseData,
Request->Req.FileSystemControl.Buffer.Size); Request->Req.FileSystemControl.Buffer.Size);
} }
break; break;
case FSCTL_DELETE_REPARSE_POINT: case FSCTL_DELETE_REPARSE_POINT:
if (0 != FileSystem->Interface->SetReparsePoint) if (0 != FileSystem->Interface->GetReparsePoint &&
Result = FileSystem->Interface->SetReparsePoint(FileSystem, Request, 0 != FileSystem->Interface->SetReparsePoint)
(PVOID)Request->Req.FileSystemControl.UserContext, {
(PWSTR)Request->Buffer, 0, 0); GetReparseData = (PREPARSE_DATA_BUFFER)Response->Buffer;
memset(GetReparseData, 0, sizeof *GetReparseData);
if (FileSystem->ReparsePointsSymlinkOnly)
{
GetReparseData->ReparseTag = IO_REPARSE_TAG_SYMLINK;
Result = STATUS_SUCCESS;
}
else
{
Size = FSP_FSCTL_TRANSACT_RSP_SIZEMAX - FIELD_OFFSET(FSP_FSCTL_TRANSACT_RSP, Buffer);
Result = FileSystem->Interface->GetReparsePoint(FileSystem, Request,
(PVOID)Request->Req.FileSystemControl.UserContext,
(PWSTR)Request->Buffer, GetReparseData, &Size);
}
if (NT_SUCCESS(Result))
{
SetReparseData = (PREPARSE_DATA_BUFFER)
(Request->Buffer + Request->Req.FileSystemControl.Buffer.Offset);
if (GetReparseData->ReparseTag != SetReparseData->ReparseTag)
Result = STATUS_IO_REPARSE_TAG_MISMATCH;
else if (!IsReparseTagMicrosoft(SetReparseData->ReparseTag) && (
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data1 !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data1 ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data2 !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data2 ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data3 !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data3 ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data4[0] !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data4[0] ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data4[1] !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data4[1] ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data4[2] !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data4[2] ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data4[3] !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data4[3] ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data4[4] !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data4[4] ||
((PREPARSE_GUID_DATA_BUFFER)GetReparseData)->ReparseGuid.Data4[5] !=
((PREPARSE_GUID_DATA_BUFFER)SetReparseData)->ReparseGuid.Data4[5]))
Result = STATUS_REPARSE_ATTRIBUTE_CONFLICT;
if (NT_SUCCESS(Result))
Result = FileSystem->Interface->SetReparsePoint(FileSystem, Request,
(PVOID)Request->Req.FileSystemControl.UserContext,
(PWSTR)Request->Buffer, 0, 0);
}
}
break; break;
} }