From 8ccd44a1f75cc03c40b9fa260f71beb120ef7f90 Mon Sep 17 00:00:00 2001 From: Bill Zissimopoulos Date: Fri, 13 May 2016 10:00:54 -0700 Subject: [PATCH] launcher, launchctl: refactoring --- src/launcher/launchctl.c | 13 ++++++------- src/launcher/launcher.c | 2 -- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/launcher/launchctl.c b/src/launcher/launchctl.c index ded89b60..fd289bf6 100644 --- a/src/launcher/launchctl.c +++ b/src/launcher/launchctl.c @@ -78,16 +78,15 @@ static int call_pipe_and_report(PWSTR PipeBuf, ULONG SendSize, ULONG RecvSize) info("OK"); else { + ULONG Count = 0; + for (PWSTR P = PipeBuf, PipeBufEnd = P + BytesTransferred / sizeof(WCHAR); PipeBufEnd > P; P++) - switch (*P) + if (L'\0' == *P) { - case L'\0': - *P = L'\n'; - break; - case L'\1': - *P = L' '; - break; + /* print a newline every 2 nulls; this works for both list and info */ + *P = 1 == Count % 2 ? L'\n' : L' '; + Count++; } if (BytesTransferred < RecvSize) diff --git a/src/launcher/launcher.c b/src/launcher/launcher.c index 47ddf012..af8fc225 100644 --- a/src/launcher/launcher.c +++ b/src/launcher/launcher.c @@ -443,9 +443,7 @@ NTSTATUS SvcInstanceGetNameList(HANDLE ClientToken, if (BufferEnd < P + ClassNameSize + InstanceNameSize) break; - ClassNameSize--; memcpy(P, SvcInstance->ClassName, ClassNameSize * sizeof(WCHAR)); P += ClassNameSize; - *Buffer++ = L'\1'; memcpy(P, SvcInstance->InstanceName, InstanceNameSize * sizeof(WCHAR)); P += InstanceNameSize; }