Public/winfsp
1
0
Fork 0
mirror of https://github.com/winfsp/winfsp.git synced 2025-04-23 00:43:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

sys: FspVolumeTransact: reference/dereference the Fsvol device extension

Browse Source
This commit is contained in:
Bill Zissimopoulos 2016-02-12 15:10:10 -08:00
parent fc790a4c3e
commit a230ecc87c
1 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/sys/volume.c
View File

@ -500,6 +500,7 @@ NTSTATUS FspVolumeTransact(
ASSERT(0 != IrpSp->FileObject->FsContext2); ASSERT(0 != IrpSp->FileObject->FsContext2);
/* check parameters */ /* check parameters */
PDEVICE_OBJECT FsvolDeviceObject = IrpSp->FileObject->FsContext2;
ULONG InputBufferLength = IrpSp->Parameters.FileSystemControl.InputBufferLength; ULONG InputBufferLength = IrpSp->Parameters.FileSystemControl.InputBufferLength;
ULONG OutputBufferLength = IrpSp->Parameters.FileSystemControl.OutputBufferLength; ULONG OutputBufferLength = IrpSp->Parameters.FileSystemControl.OutputBufferLength;
PVOID SystemBuffer = Irp->AssociatedIrp.SystemBuffer; PVOID SystemBuffer = Irp->AssociatedIrp.SystemBuffer;
@ -511,8 +512,10 @@ NTSTATUS FspVolumeTransact(
FSP_FSCTL_TRANSACT_REQ_BUFFER_SIZEMIN > OutputBufferLength) FSP_FSCTL_TRANSACT_REQ_BUFFER_SIZEMIN > OutputBufferLength)
return STATUS_BUFFER_TOO_SMALL; return STATUS_BUFFER_TOO_SMALL;
if (!FspDeviceReference(FsvolDeviceObject))
return STATUS_CANCELLED;
NTSTATUS Result; NTSTATUS Result;
PDEVICE_OBJECT FsvolDeviceObject = IrpSp->FileObject->FsContext2;
FSP_FSVOL_DEVICE_EXTENSION *FsvolDeviceExtension = FspFsvolDeviceExtension(FsvolDeviceObject); FSP_FSVOL_DEVICE_EXTENSION *FsvolDeviceExtension = FspFsvolDeviceExtension(FsvolDeviceObject);
PUINT8 BufferEnd; PUINT8 BufferEnd;
FSP_FSCTL_TRANSACT_RSP *Response, *NextResponse; FSP_FSCTL_TRANSACT_RSP *Response, *NextResponse;
@ -535,6 +538,9 @@ NTSTATUS FspVolumeTransact(
/* either IRP was canceled or a bogus Hint was provided */ /* either IRP was canceled or a bogus Hint was provided */
continue; continue;
ASSERT((UINT_PTR)ProcessIrp == (UINT_PTR)Response->Hint);
ASSERT(FspIrpRequest(ProcessIrp)->Hint == Response->Hint);
Result = FspIopDispatchComplete(ProcessIrp, Response); Result = FspIopDispatchComplete(ProcessIrp, Response);
if (STATUS_PENDING == Result) if (STATUS_PENDING == Result)
{ {
@ -574,7 +580,8 @@ NTSTATUS FspVolumeTransact(
if (0 == Irp->MdlAddress) if (0 == Irp->MdlAddress)
{ {
Irp->IoStatus.Information = 0; Irp->IoStatus.Information = 0;
return STATUS_SUCCESS; Result = STATUS_SUCCESS;
goto exit;
} }
MdlBuffer = MmGetMdlVirtualAddress(Irp->MdlAddress); MdlBuffer = MmGetMdlVirtualAddress(Irp->MdlAddress);
ASSERT(0 != MdlBuffer); ASSERT(0 != MdlBuffer);
@ -586,12 +593,16 @@ NTSTATUS FspVolumeTransact(
while (0 == (PendingIrp = FspIoqNextPendingIrp(FsvolDeviceExtension->Ioq, 0, &Timeout))) while (0 == (PendingIrp = FspIoqNextPendingIrp(FsvolDeviceExtension->Ioq, 0, &Timeout)))
{ {
if (FspIoqStopped(FsvolDeviceExtension->Ioq)) if (FspIoqStopped(FsvolDeviceExtension->Ioq))
return STATUS_CANCELLED; {
Result = STATUS_CANCELLED;
goto exit;
}
} }
if (FspIoqTimeout == PendingIrp) if (FspIoqTimeout == PendingIrp)
{ {
Irp->IoStatus.Information = 0; Irp->IoStatus.Information = 0;
return STATUS_SUCCESS; Result = STATUS_SUCCESS;
goto exit;
} }
/* send any pending IRP's to the user-mode file system */ /* send any pending IRP's to the user-mode file system */
@ -630,7 +641,8 @@ NTSTATUS FspVolumeTransact(
*/ */
ASSERT(FspIoqStopped(FsvolDeviceExtension->Ioq)); ASSERT(FspIoqStopped(FsvolDeviceExtension->Ioq));
FspIopCompleteCanceledIrp(PendingIrp); FspIopCompleteCanceledIrp(PendingIrp);
return STATUS_CANCELLED; Result = STATUS_CANCELLED;
goto exit;
} }
/* check that we have enough space before pulling the next pending IRP off the queue */ /* check that we have enough space before pulling the next pending IRP off the queue */
@ -645,7 +657,11 @@ NTSTATUS FspVolumeTransact(
} }
Irp->IoStatus.Information = (PUINT8)Request - (PUINT8)MdlBuffer; Irp->IoStatus.Information = (PUINT8)Request - (PUINT8)MdlBuffer;
return STATUS_SUCCESS; Result = STATUS_SUCCESS;
exit:
FspDeviceDereference(FsvolDeviceObject);
return Result;
} }
NTSTATUS FspVolumeWork( NTSTATUS FspVolumeWork(