Public/winfsp
1
0
Fork 0
mirror of https://github.com/winfsp/winfsp.git synced 2025-06-08 04:52:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

sys: FspFsvolNotifyChangeDirectory: fix problem with accessing IRP in FspFileNodeRelease when FspNotifyChangeDirectory completes IRP immediately

Browse Source
This commit is contained in:
Bill Zissimopoulos 2016-04-10 22:12:20 -07:00
parent 83e40f522c
commit adb6819de1
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/sys/dirctl.c
View File

@ -632,6 +632,17 @@ static NTSTATUS FspFsvolNotifyChangeDirectory(
return Result;
}
/*
* It is possible for FspNotifyChangeDirectory to complete the IRP immediately.
* In this case trying to access the IRP (to get its IrpFlags) in FspFileNodeRelease
* can lead to a bugcheck. For this reason we set the TopLevelIrp to NULL here.
*
* IRP_MN_NOTIFY_CHANGE_DIRECTORY does not need the TopLevelIrp functionality,
* because it cannot be used recursively (I believe -- famous last words).
*/
PIRP TopLevelIrp = IoGetTopLevelIrp();
IoSetTopLevelIrp(0);
FspFileNodeAcquireExclusive(FileNode, Main);
Result = FspNotifyChangeDirectory(
@ -647,6 +658,9 @@ static NTSTATUS FspFsvolNotifyChangeDirectory(
if (!NT_SUCCESS(Result))
{
/* set back the top level IRP just in case! */
IoSetTopLevelIrp(TopLevelIrp);
FspIrpHookReset(Irp);
FspFree(CompletionContext);
return Result;