Public/winfsp
1
0
Fork 0
mirror of https://github.com/winfsp/winfsp.git synced 2025-04-22 16:33:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix 32 bit overflow issue in FspFsvolReadCached.

Browse Source 
FspFsvolReadCached takes care not to read beyond the end of the file.
However, the offset check uses a 32 bit comparison, which fails for
files >= 4G.  As a result, reads on a large file will skip blocks at
offset (filesize % 4G), and those blocks will zero-filled.
This commit is contained in:
Felix A. Croes 2019-03-07 09:45:42 +01:00
parent d2de5e996c
commit b350dffe6c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/sys/read.c
View File

@ -150,7 +150,7 @@ static NTSTATUS FspFsvolReadCached(
FspFileNodeRelease(FileNode, Main); FspFileNodeRelease(FileNode, Main);
return STATUS_END_OF_FILE; return STATUS_END_OF_FILE;
} }
if (ReadLength > (ULONG)(FileInfo.FileSize - ReadOffset.QuadPart)) if ((UINT64)ReadLength > FileInfo.FileSize - ReadOffset.QuadPart)
ReadLength = (ULONG)(FileInfo.FileSize - ReadOffset.QuadPart); ReadLength = (ULONG)(FileInfo.FileSize - ReadOffset.QuadPart);
/* initialize cache if not already initialized! */ /* initialize cache if not already initialized! */