Public/winfsp
1
0
Fork 0
mirror of https://github.com/winfsp/winfsp.git synced 2025-04-23 00:43:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

launcher: security model improvements

Browse Source
This commit is contained in:
Bill Zissimopoulos 2016-05-12 15:31:35 -07:00
parent 1c587dbcb7
commit c42e2a5958
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/launcher/launcher.c
View File

@ -221,11 +221,8 @@ NTSTATUS SvcInstanceCreate(HANDLE ClientToken,
RegKey = 0; RegKey = 0;
if (L'\0' == Security) if (L'\0' == Security)
{
Security = SecurityBuf;
lstrcpyW(Security, L"" SVC_INSTANCE_DEFAULT_SDDL); lstrcpyW(Security, L"" SVC_INSTANCE_DEFAULT_SDDL);
} if (L'D' == Security[0] && L':' == Security[1])
else if (L'D' == Security[0] && L':' == Security[1])
Security = SecurityBuf; Security = SecurityBuf;
if (!ConvertStringSecurityDescriptorToSecurityDescriptorW(Security, SDDL_REVISION_1, if (!ConvertStringSecurityDescriptorToSecurityDescriptorW(Security, SDDL_REVISION_1,

12
src/launcher/launcher.h
View File

@ -22,19 +22,25 @@
#include <shared/minimal.h> #include <shared/minimal.h>
#define PIPE_NAME "\\\\.\\pipe\\WinFsp.{14E7137D-22B4-437A-B0C1-D21D1BDF3767}" #define PIPE_NAME "\\\\.\\pipe\\WinFsp.{14E7137D-22B4-437A-B0C1-D21D1BDF3767}"
#define PIPE_SDDL "O:SYG:SYD:P(A;;GA;;;WD)"
#define PIPE_BUFFER_SIZE 2048 #define PIPE_BUFFER_SIZE 2048
#define PIPE_DEFAULT_TIMEOUT 3000 #define PIPE_DEFAULT_TIMEOUT 3000
/* RP:SERVICE_START, WP:SERVICE_STOP, SC:SERVICE_QUERY_STATUS */
/* /*
* The launcher named pipe SDDL gives full access to LocalSystem and Administrators.
* It also gives generic read access and FILE_WRITE_DATA (SC) to Everyone. Note that
* we cannot give generic write access or equivalently FILE_GENERIC_WRITE (FW) because
* we would also grant the FILE_CREATE_PIPE_INSTANCE right.
*/
#define PIPE_SDDL "D:P(A;;GA;;;SY)(A;;GA;;;BA)(A;;GRSC;;;WD)"
/*
* The default service instance SDDL gives full access to LocalSystem and Administrators. * The default service instance SDDL gives full access to LocalSystem and Administrators.
* The only possible service instance rights are as follows: * The only possible service instance rights are as follows:
* RP SERVICE_START * RP SERVICE_START
* WP SERVICE_STOP * WP SERVICE_STOP
* SC SERVICE_QUERY_STATUS * SC SERVICE_QUERY_STATUS
* *
* To create a service that can be started, stopped or queried by everyone, you can set * To create a service that can be started, stopped or queried by Everyone, you can set
* the following SDDL: * the following SDDL:
* D:P(A;;RPWPSC;;;WD) * D:P(A;;RPWPSC;;;WD)
*/ */