From dfe45e1be5c3c0ab2cda6ef18a83ebd92be6d458 Mon Sep 17 00:00:00 2001 From: Bill Zissimopoulos Date: Wed, 26 Oct 2016 13:27:49 -0700 Subject: [PATCH] tst: winfsp-tests: WIP --- tst/winfsp-tests/create-test.c | 10 +++++++++- tst/winfsp-tests/stream-tests.c | 10 +++++++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tst/winfsp-tests/create-test.c b/tst/winfsp-tests/create-test.c index 26ac2b90..407374a5 100644 --- a/tst/winfsp-tests/create-test.c +++ b/tst/winfsp-tests/create-test.c @@ -483,7 +483,15 @@ void create_notraverse_dotest(ULONG Flags, PWSTR Prefix) void create_notraverse_test(void) { if (OptNoTraverseToken) - return; /* this test needs traverse access privilege in order to work */ + /* this test needs traverse access privilege in order to work */ + return; + + if (OptShareName) + /* + * This test does not work when going through a share! + * Does this suggest that traverse privilege is always on when going through shares? + */ + return; if (NtfsTests) { diff --git a/tst/winfsp-tests/stream-tests.c b/tst/winfsp-tests/stream-tests.c index 69f9711d..08ec8d29 100644 --- a/tst/winfsp-tests/stream-tests.c +++ b/tst/winfsp-tests/stream-tests.c @@ -329,9 +329,13 @@ static void stream_create_dotest(ULONG Flags, PWSTR Prefix) StringCbPrintfW(FilePath, sizeof FilePath, L"%s%s\\dir1::$DATA", Prefix ? L"" : L"\\\\?\\GLOBALROOT", Prefix ? Prefix : memfs_volumename(memfs)); - Success = CreateDirectoryW(FilePath, 0); - ASSERT(!Success); - ASSERT(ERROR_DIRECTORY == GetLastError()); + if (!OptShareName) + { + /* this CreateDirectory actually succeeds when going through a share! */ + Success = CreateDirectoryW(FilePath, 0); + ASSERT(!Success); + ASSERT(ERROR_DIRECTORY == GetLastError()); + } memfs_stop(memfs); }