BlockStorage/repertory
1
0
Fork 0
Code Issues 8 Pull Requests Releases 6 Wiki Activity

[bug] S3 error responses are not being logged #29

Browse Source
This commit is contained in:
Scott E. Graves 2024-12-31 08:46:17 -06:00
parent 4e86f2a7de
commit bc43338127
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
repertory/librepertory/src/providers/s3/s3_provider.cpp
View File

@ -955,10 +955,13 @@ auto s3_provider::remove_file_impl(const std::string &api_path) -> api_error {
auto object_name =
utils::path::create_api_path(is_encrypted ? key : api_path);
curl::requests::http_delete del{};
std::string response_data : curl::requests::http_delete del{};
del.allow_timeout = true;
del.aws_service = "aws:amz:" + cfg.region + ":s3";
del.path = object_name;
del.response_handler = [&response_data](auto &&data, long /*response_code*/) {
response_data = std::string(data.begin(), data.end());
};
long response_code{};
stop_type stop_requested{};
@ -972,8 +975,9 @@ auto s3_provider::remove_file_impl(const std::string &api_path) -> api_error {
if ((response_code < http_error_codes::ok ||
response_code >= http_error_codes::multiple_choices) &&
response_code != http_error_codes::not_found) {
utils::error::raise_api_path_error(function_name, api_path, response_code,
"failed to remove file");
utils::error::raise_api_path_error(
function_name, api_path, response_code,
fmt::format("failed to remove file|response|{}", response_data));
return api_error::comm_error;
}