sys: static analysis fixes

This commit is contained in:
Bill Zissimopoulos 2015-11-28 00:01:39 -08:00
parent 97c98ac265
commit d7e9a25d37
14 changed files with 70 additions and 80 deletions

View File

@ -40,7 +40,7 @@ NTSTATUS FspDeviceControl(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspDeviceControlComplete(
@ -48,5 +48,5 @@ VOID FspDeviceControlComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -40,7 +40,7 @@ NTSTATUS FspDirectoryControl(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspDirectoryControlComplete(
@ -48,5 +48,5 @@ VOID FspDirectoryControlComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -14,10 +14,8 @@ DRIVER_UNLOAD FspUnload;
#pragma alloc_text(PAGE, FspUnload)
#endif
NTSTATUS
DriverEntry(
_In_ PDRIVER_OBJECT DriverObject,
_In_ PUNICODE_STRING RegistryPath)
NTSTATUS DriverEntry(
PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath)
{
FSP_ENTER();
@ -117,6 +115,7 @@ DriverEntry(
FspFastIoDispatch.ReleaseForModWrite = FspReleaseForModWrite;
FspFastIoDispatch.AcquireForCcFlush = FspAcquireForCcFlush;
FspFastIoDispatch.ReleaseForCcFlush = FspReleaseForCcFlush;
#pragma prefast(suppress:28175, "We are a filesystem: ok to touch FastIoDispatch")
DriverObject->FastIoDispatch = &FspFastIoDispatch;
/* register our device objects as file systems */
@ -127,9 +126,8 @@ DriverEntry(
&DriverObject->DriverName, RegistryPath);
}
VOID
FspUnload(
_In_ PDRIVER_OBJECT DriverObject)
VOID FspUnload(
PDRIVER_OBJECT DriverObject)
{
FSP_ENTER_VOID(PAGED_CODE());

View File

@ -55,7 +55,7 @@ NTSTATUS FspQueryEa(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
NTSTATUS FspSetEa(
@ -73,7 +73,7 @@ NTSTATUS FspSetEa(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspQueryEaComplete(
@ -81,7 +81,7 @@ VOID FspQueryEaComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}
VOID FspSetEaComplete(
@ -89,5 +89,5 @@ VOID FspSetEaComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -12,21 +12,19 @@ FAST_IO_CHECK_IF_POSSIBLE FspFastIoCheckIfPossible;
#pragma alloc_text(PAGE, FspFastIoCheckIfPossible)
#endif
BOOLEAN
FspFastIoCheckIfPossible(
_In_ PFILE_OBJECT FileObject,
_In_ PLARGE_INTEGER FileOffset,
_In_ ULONG Length,
_In_ BOOLEAN Wait,
_In_ ULONG LockKey,
_In_ BOOLEAN CheckForReadOperation,
_Out_ PIO_STATUS_BLOCK IoStatus,
_In_ PDEVICE_OBJECT DeviceObject
)
BOOLEAN FspFastIoCheckIfPossible(
PFILE_OBJECT FileObject,
PLARGE_INTEGER FileOffset,
ULONG Length,
BOOLEAN Wait,
ULONG LockKey,
BOOLEAN CheckForReadOperation,
PIO_STATUS_BLOCK IoStatus,
PDEVICE_OBJECT DeviceObject)
{
FSP_ENTER_BOOL(PAGED_CODE());
Result = FALSE;
FSP_LEAVE_BOOL("", 0);
FSP_LEAVE_BOOL("%s", "");
}

View File

@ -55,7 +55,7 @@ NTSTATUS FspQueryInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
NTSTATUS FspSetInformation(
@ -73,7 +73,7 @@ NTSTATUS FspSetInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspQueryInformationComplete(
@ -81,7 +81,7 @@ VOID FspQueryInformationComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}
VOID FspSetInformationComplete(
@ -89,5 +89,5 @@ VOID FspSetInformationComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -40,7 +40,7 @@ NTSTATUS FspFlushBuffers(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspFlushBuffersComplete(
@ -48,5 +48,5 @@ VOID FspFlushBuffersComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -40,7 +40,7 @@ NTSTATUS FspLockControl(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspLockControlComplete(
@ -48,5 +48,5 @@ VOID FspLockControlComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -40,7 +40,7 @@ NTSTATUS FspRead(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspReadComplete(
@ -48,5 +48,5 @@ VOID FspReadComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -22,71 +22,65 @@ FAST_IO_RELEASE_FOR_CCFLUSH FspReleaseForCcFlush;
#pragma alloc_text(PAGE, FspReleaseForCcFlush)
#endif
VOID
FspAcquireFileForNtCreateSection(
_In_ PFILE_OBJECT FileObject)
VOID FspAcquireFileForNtCreateSection(
PFILE_OBJECT FileObject)
{
FSP_ENTER_VOID(PAGED_CODE());
FSP_LEAVE_VOID("", 0);
FSP_LEAVE_VOID("%s", "");
}
VOID
FspReleaseFileForNtCreateSection(
_In_ PFILE_OBJECT FileObject)
VOID FspReleaseFileForNtCreateSection(
PFILE_OBJECT FileObject)
{
FSP_ENTER_VOID(PAGED_CODE());
FSP_LEAVE_VOID("", 0);
FSP_LEAVE_VOID("%s", "");
}
NTSTATUS
FspAcquireForModWrite(
_In_ PFILE_OBJECT FileObject,
_In_ PLARGE_INTEGER EndingOffset,
_Out_ PERESOURCE *ResourceToRelease,
_In_ PDEVICE_OBJECT DeviceObject)
NTSTATUS FspAcquireForModWrite(
PFILE_OBJECT FileObject,
PLARGE_INTEGER EndingOffset,
PERESOURCE *ResourceToRelease,
PDEVICE_OBJECT DeviceObject)
{
FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0);
FSP_LEAVE("%s", "");
}
NTSTATUS
FspReleaseForModWrite(
_In_ PFILE_OBJECT FileObject,
_In_ PERESOURCE ResourceToRelease,
_In_ PDEVICE_OBJECT DeviceObject)
NTSTATUS FspReleaseForModWrite(
PFILE_OBJECT FileObject,
PERESOURCE ResourceToRelease,
PDEVICE_OBJECT DeviceObject)
{
FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0);
FSP_LEAVE("%s", "");
}
NTSTATUS
FspAcquireForCcFlush(
_In_ PFILE_OBJECT FileObject,
_In_ PDEVICE_OBJECT DeviceObject)
NTSTATUS FspAcquireForCcFlush(
PFILE_OBJECT FileObject,
PDEVICE_OBJECT DeviceObject)
{
FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0);
FSP_LEAVE("%s", "");
}
NTSTATUS
FspReleaseForCcFlush(
_In_ PFILE_OBJECT FileObject,
_In_ PDEVICE_OBJECT DeviceObject)
NTSTATUS FspReleaseForCcFlush(
PFILE_OBJECT FileObject,
PDEVICE_OBJECT DeviceObject)
{
FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0);
FSP_LEAVE("%s", "");
}

View File

@ -55,7 +55,7 @@ NTSTATUS FspQuerySecurity(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
NTSTATUS FspSetSecurity(
@ -73,7 +73,7 @@ NTSTATUS FspSetSecurity(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspQuerySecurityComplete(
@ -81,7 +81,7 @@ VOID FspQuerySecurityComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}
VOID FspSetSecurityComplete(
@ -89,5 +89,5 @@ VOID FspSetSecurityComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -40,7 +40,7 @@ NTSTATUS FspShutdown(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspShutdownComplete(
@ -48,5 +48,5 @@ VOID FspShutdownComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -55,7 +55,7 @@ NTSTATUS FspQueryVolumeInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
NTSTATUS FspSetVolumeInformation(
@ -73,7 +73,7 @@ NTSTATUS FspSetVolumeInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspQueryVolumeInformationComplete(
@ -81,7 +81,7 @@ VOID FspQueryVolumeInformationComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}
VOID FspSetVolumeInformationComplete(
@ -89,5 +89,5 @@ VOID FspSetVolumeInformationComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}

View File

@ -40,7 +40,7 @@ NTSTATUS FspWrite(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
}
FSP_LEAVE_MJ("", 0);
FSP_LEAVE_MJ("%s", "");
}
VOID FspWriteComplete(
@ -48,5 +48,5 @@ VOID FspWriteComplete(
{
FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0);
FSP_LEAVE_IOC("%s", "");
}