sys: static analysis fixes

This commit is contained in:
Bill Zissimopoulos 2015-11-28 00:01:39 -08:00
parent 97c98ac265
commit d7e9a25d37
14 changed files with 70 additions and 80 deletions

View File

@ -40,7 +40,7 @@ NTSTATUS FspDeviceControl(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspDeviceControlComplete( VOID FspDeviceControlComplete(
@ -48,5 +48,5 @@ VOID FspDeviceControlComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -40,7 +40,7 @@ NTSTATUS FspDirectoryControl(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspDirectoryControlComplete( VOID FspDirectoryControlComplete(
@ -48,5 +48,5 @@ VOID FspDirectoryControlComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -14,10 +14,8 @@ DRIVER_UNLOAD FspUnload;
#pragma alloc_text(PAGE, FspUnload) #pragma alloc_text(PAGE, FspUnload)
#endif #endif
NTSTATUS NTSTATUS DriverEntry(
DriverEntry( PDRIVER_OBJECT DriverObject, PUNICODE_STRING RegistryPath)
_In_ PDRIVER_OBJECT DriverObject,
_In_ PUNICODE_STRING RegistryPath)
{ {
FSP_ENTER(); FSP_ENTER();
@ -117,6 +115,7 @@ DriverEntry(
FspFastIoDispatch.ReleaseForModWrite = FspReleaseForModWrite; FspFastIoDispatch.ReleaseForModWrite = FspReleaseForModWrite;
FspFastIoDispatch.AcquireForCcFlush = FspAcquireForCcFlush; FspFastIoDispatch.AcquireForCcFlush = FspAcquireForCcFlush;
FspFastIoDispatch.ReleaseForCcFlush = FspReleaseForCcFlush; FspFastIoDispatch.ReleaseForCcFlush = FspReleaseForCcFlush;
#pragma prefast(suppress:28175, "We are a filesystem: ok to touch FastIoDispatch")
DriverObject->FastIoDispatch = &FspFastIoDispatch; DriverObject->FastIoDispatch = &FspFastIoDispatch;
/* register our device objects as file systems */ /* register our device objects as file systems */
@ -127,9 +126,8 @@ DriverEntry(
&DriverObject->DriverName, RegistryPath); &DriverObject->DriverName, RegistryPath);
} }
VOID VOID FspUnload(
FspUnload( PDRIVER_OBJECT DriverObject)
_In_ PDRIVER_OBJECT DriverObject)
{ {
FSP_ENTER_VOID(PAGED_CODE()); FSP_ENTER_VOID(PAGED_CODE());

View File

@ -55,7 +55,7 @@ NTSTATUS FspQueryEa(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
NTSTATUS FspSetEa( NTSTATUS FspSetEa(
@ -73,7 +73,7 @@ NTSTATUS FspSetEa(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspQueryEaComplete( VOID FspQueryEaComplete(
@ -81,7 +81,7 @@ VOID FspQueryEaComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }
VOID FspSetEaComplete( VOID FspSetEaComplete(
@ -89,5 +89,5 @@ VOID FspSetEaComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -12,21 +12,19 @@ FAST_IO_CHECK_IF_POSSIBLE FspFastIoCheckIfPossible;
#pragma alloc_text(PAGE, FspFastIoCheckIfPossible) #pragma alloc_text(PAGE, FspFastIoCheckIfPossible)
#endif #endif
BOOLEAN BOOLEAN FspFastIoCheckIfPossible(
FspFastIoCheckIfPossible( PFILE_OBJECT FileObject,
_In_ PFILE_OBJECT FileObject, PLARGE_INTEGER FileOffset,
_In_ PLARGE_INTEGER FileOffset, ULONG Length,
_In_ ULONG Length, BOOLEAN Wait,
_In_ BOOLEAN Wait, ULONG LockKey,
_In_ ULONG LockKey, BOOLEAN CheckForReadOperation,
_In_ BOOLEAN CheckForReadOperation, PIO_STATUS_BLOCK IoStatus,
_Out_ PIO_STATUS_BLOCK IoStatus, PDEVICE_OBJECT DeviceObject)
_In_ PDEVICE_OBJECT DeviceObject
)
{ {
FSP_ENTER_BOOL(PAGED_CODE()); FSP_ENTER_BOOL(PAGED_CODE());
Result = FALSE; Result = FALSE;
FSP_LEAVE_BOOL("", 0); FSP_LEAVE_BOOL("%s", "");
} }

View File

@ -55,7 +55,7 @@ NTSTATUS FspQueryInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
NTSTATUS FspSetInformation( NTSTATUS FspSetInformation(
@ -73,7 +73,7 @@ NTSTATUS FspSetInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspQueryInformationComplete( VOID FspQueryInformationComplete(
@ -81,7 +81,7 @@ VOID FspQueryInformationComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }
VOID FspSetInformationComplete( VOID FspSetInformationComplete(
@ -89,5 +89,5 @@ VOID FspSetInformationComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -40,7 +40,7 @@ NTSTATUS FspFlushBuffers(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspFlushBuffersComplete( VOID FspFlushBuffersComplete(
@ -48,5 +48,5 @@ VOID FspFlushBuffersComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -40,7 +40,7 @@ NTSTATUS FspLockControl(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspLockControlComplete( VOID FspLockControlComplete(
@ -48,5 +48,5 @@ VOID FspLockControlComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -40,7 +40,7 @@ NTSTATUS FspRead(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspReadComplete( VOID FspReadComplete(
@ -48,5 +48,5 @@ VOID FspReadComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -22,71 +22,65 @@ FAST_IO_RELEASE_FOR_CCFLUSH FspReleaseForCcFlush;
#pragma alloc_text(PAGE, FspReleaseForCcFlush) #pragma alloc_text(PAGE, FspReleaseForCcFlush)
#endif #endif
VOID VOID FspAcquireFileForNtCreateSection(
FspAcquireFileForNtCreateSection( PFILE_OBJECT FileObject)
_In_ PFILE_OBJECT FileObject)
{ {
FSP_ENTER_VOID(PAGED_CODE()); FSP_ENTER_VOID(PAGED_CODE());
FSP_LEAVE_VOID("", 0); FSP_LEAVE_VOID("%s", "");
} }
VOID VOID FspReleaseFileForNtCreateSection(
FspReleaseFileForNtCreateSection( PFILE_OBJECT FileObject)
_In_ PFILE_OBJECT FileObject)
{ {
FSP_ENTER_VOID(PAGED_CODE()); FSP_ENTER_VOID(PAGED_CODE());
FSP_LEAVE_VOID("", 0); FSP_LEAVE_VOID("%s", "");
} }
NTSTATUS NTSTATUS FspAcquireForModWrite(
FspAcquireForModWrite( PFILE_OBJECT FileObject,
_In_ PFILE_OBJECT FileObject, PLARGE_INTEGER EndingOffset,
_In_ PLARGE_INTEGER EndingOffset, PERESOURCE *ResourceToRelease,
_Out_ PERESOURCE *ResourceToRelease, PDEVICE_OBJECT DeviceObject)
_In_ PDEVICE_OBJECT DeviceObject)
{ {
FSP_ENTER(PAGED_CODE()); FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED; Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0); FSP_LEAVE("%s", "");
} }
NTSTATUS NTSTATUS FspReleaseForModWrite(
FspReleaseForModWrite( PFILE_OBJECT FileObject,
_In_ PFILE_OBJECT FileObject, PERESOURCE ResourceToRelease,
_In_ PERESOURCE ResourceToRelease, PDEVICE_OBJECT DeviceObject)
_In_ PDEVICE_OBJECT DeviceObject)
{ {
FSP_ENTER(PAGED_CODE()); FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED; Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0); FSP_LEAVE("%s", "");
} }
NTSTATUS NTSTATUS FspAcquireForCcFlush(
FspAcquireForCcFlush( PFILE_OBJECT FileObject,
_In_ PFILE_OBJECT FileObject, PDEVICE_OBJECT DeviceObject)
_In_ PDEVICE_OBJECT DeviceObject)
{ {
FSP_ENTER(PAGED_CODE()); FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED; Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0); FSP_LEAVE("%s", "");
} }
NTSTATUS NTSTATUS FspReleaseForCcFlush(
FspReleaseForCcFlush( PFILE_OBJECT FileObject,
_In_ PFILE_OBJECT FileObject, PDEVICE_OBJECT DeviceObject)
_In_ PDEVICE_OBJECT DeviceObject)
{ {
FSP_ENTER(PAGED_CODE()); FSP_ENTER(PAGED_CODE());
Result = STATUS_NOT_IMPLEMENTED; Result = STATUS_NOT_IMPLEMENTED;
FSP_LEAVE("", 0); FSP_LEAVE("%s", "");
} }

View File

@ -55,7 +55,7 @@ NTSTATUS FspQuerySecurity(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
NTSTATUS FspSetSecurity( NTSTATUS FspSetSecurity(
@ -73,7 +73,7 @@ NTSTATUS FspSetSecurity(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspQuerySecurityComplete( VOID FspQuerySecurityComplete(
@ -81,7 +81,7 @@ VOID FspQuerySecurityComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }
VOID FspSetSecurityComplete( VOID FspSetSecurityComplete(
@ -89,5 +89,5 @@ VOID FspSetSecurityComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -40,7 +40,7 @@ NTSTATUS FspShutdown(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspShutdownComplete( VOID FspShutdownComplete(
@ -48,5 +48,5 @@ VOID FspShutdownComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -55,7 +55,7 @@ NTSTATUS FspQueryVolumeInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
NTSTATUS FspSetVolumeInformation( NTSTATUS FspSetVolumeInformation(
@ -73,7 +73,7 @@ NTSTATUS FspSetVolumeInformation(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspQueryVolumeInformationComplete( VOID FspQueryVolumeInformationComplete(
@ -81,7 +81,7 @@ VOID FspQueryVolumeInformationComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }
VOID FspSetVolumeInformationComplete( VOID FspSetVolumeInformationComplete(
@ -89,5 +89,5 @@ VOID FspSetVolumeInformationComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }

View File

@ -40,7 +40,7 @@ NTSTATUS FspWrite(
FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST); FSP_RETURN(Result = STATUS_INVALID_DEVICE_REQUEST);
} }
FSP_LEAVE_MJ("", 0); FSP_LEAVE_MJ("%s", "");
} }
VOID FspWriteComplete( VOID FspWriteComplete(
@ -48,5 +48,5 @@ VOID FspWriteComplete(
{ {
FSP_ENTER_IOC(PAGED_CODE()); FSP_ENTER_IOC(PAGED_CODE());
FSP_LEAVE_IOC("", 0); FSP_LEAVE_IOC("%s", "");
} }